You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@giraph.apache.org by Avery Ching <av...@gmail.com> on 2013/05/06 23:19:14 UTC
Review Request: GIRAPH-621
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10960/
-----------------------------------------------------------
Review request for giraph.
Description
-------
Add an introduction to Giraph to User Docs. Simplify the main landing page.
Diffs
-----
src/site/resources/images/ExampleSSSP.svg PRE-CREATION
src/site/site.xml 695677258ffbc32d66e196986d83f66480ee2d0e
src/site/xdoc/build.xml PRE-CREATION
src/site/xdoc/implementation.xml PRE-CREATION
src/site/xdoc/index.xml 47fd8f5876a92e00815923c20137028072765f70
src/site/xdoc/intro.xml PRE-CREATION
src/site/xdoc/io.xml 76f610b1633dec77be06c28bae03bc24c4a83a9e
Diff: https://reviews.apache.org/r/10960/diff/
Testing
-------
Built the site. Available at http://people.apache.org/~aching/GIRAPH-621/index.html
Passed 'mvn clean verify'
Thanks,
Avery Ching
Re: Review Request: GIRAPH-621
Posted by Avery Ching <av...@gmail.com>.
> On May 6, 2013, 9:44 p.m., Maja Kabiljo wrote:
> >
Thanks for the quick review.
> On May 6, 2013, 9:44 p.m., Maja Kabiljo wrote:
> > src/site/xdoc/build.xml, line 59
> > <https://reviews.apache.org/r/10960/diff/2/?file=288285#file288285line59>
> >
> > Is this the right place for this comment? I'd rather put it in some FAQ.
Agreed, created a new FAQ for this.
> On May 6, 2013, 9:44 p.m., Maja Kabiljo wrote:
> > src/site/xdoc/index.xml, line 66
> > <https://reviews.apache.org/r/10960/diff/2/?file=288287#file288287line66>
> >
> > I don't get the "rather that deep technical..." part - is it supposed to be 'rather than'?
> >
> > 'a couple OF lines'?
Fixed.
- Avery
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10960/#review20234
-----------------------------------------------------------
On May 6, 2013, 9:22 p.m., Avery Ching wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10960/
> -----------------------------------------------------------
>
> (Updated May 6, 2013, 9:22 p.m.)
>
>
> Review request for giraph.
>
>
> Description
> -------
>
> Add an introduction to Giraph to User Docs. Simplify the main landing page.
>
>
> This addresses bug GIRAPH-621.
> https://issues.apache.org/jira/browse/GIRAPH-621
>
>
> Diffs
> -----
>
> src/site/resources/images/ExampleSSSP.svg PRE-CREATION
> src/site/site.xml 695677258ffbc32d66e196986d83f66480ee2d0e
> src/site/xdoc/build.xml PRE-CREATION
> src/site/xdoc/implementation.xml PRE-CREATION
> src/site/xdoc/index.xml 47fd8f5876a92e00815923c20137028072765f70
> src/site/xdoc/intro.xml PRE-CREATION
> src/site/xdoc/io.xml 76f610b1633dec77be06c28bae03bc24c4a83a9e
>
> Diff: https://reviews.apache.org/r/10960/diff/
>
>
> Testing
> -------
>
> Built the site. Available at http://people.apache.org/~aching/GIRAPH-621/index.html
> Passed 'mvn clean verify'
>
>
> Thanks,
>
> Avery Ching
>
>
Re: Review Request: GIRAPH-621
Posted by Maja Kabiljo <ma...@fb.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10960/#review20234
-----------------------------------------------------------
Ship it!
src/site/xdoc/build.xml
<https://reviews.apache.org/r/10960/#comment41498>
Is this the right place for this comment? I'd rather put it in some FAQ.
src/site/xdoc/index.xml
<https://reviews.apache.org/r/10960/#comment41496>
I don't get the "rather that deep technical..." part - is it supposed to be 'rather than'?
'a couple OF lines'?
- Maja Kabiljo
On May 6, 2013, 9:22 p.m., Avery Ching wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10960/
> -----------------------------------------------------------
>
> (Updated May 6, 2013, 9:22 p.m.)
>
>
> Review request for giraph.
>
>
> Description
> -------
>
> Add an introduction to Giraph to User Docs. Simplify the main landing page.
>
>
> This addresses bug GIRAPH-621.
> https://issues.apache.org/jira/browse/GIRAPH-621
>
>
> Diffs
> -----
>
> src/site/resources/images/ExampleSSSP.svg PRE-CREATION
> src/site/site.xml 695677258ffbc32d66e196986d83f66480ee2d0e
> src/site/xdoc/build.xml PRE-CREATION
> src/site/xdoc/implementation.xml PRE-CREATION
> src/site/xdoc/index.xml 47fd8f5876a92e00815923c20137028072765f70
> src/site/xdoc/intro.xml PRE-CREATION
> src/site/xdoc/io.xml 76f610b1633dec77be06c28bae03bc24c4a83a9e
>
> Diff: https://reviews.apache.org/r/10960/diff/
>
>
> Testing
> -------
>
> Built the site. Available at http://people.apache.org/~aching/GIRAPH-621/index.html
> Passed 'mvn clean verify'
>
>
> Thanks,
>
> Avery Ching
>
>
Re: Review Request: GIRAPH-621
Posted by Maja Kabiljo <ma...@fb.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10960/#review20242
-----------------------------------------------------------
src/site/xdoc/index.xml
<https://reviews.apache.org/r/10960/#comment41543>
One more thing: the way I see it the first paragraph of the landing page should be something simpler and not go into background details that much. What do you think?
- Maja Kabiljo
On May 6, 2013, 10:04 p.m., Avery Ching wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10960/
> -----------------------------------------------------------
>
> (Updated May 6, 2013, 10:04 p.m.)
>
>
> Review request for giraph.
>
>
> Description
> -------
>
> Add an introduction to Giraph to User Docs. Simplify the main landing page.
>
>
> This addresses bug GIRAPH-621.
> https://issues.apache.org/jira/browse/GIRAPH-621
>
>
> Diffs
> -----
>
> src/site/resources/images/ExampleSSSP.svg PRE-CREATION
> src/site/site.xml 695677258ffbc32d66e196986d83f66480ee2d0e
> src/site/xdoc/build.xml PRE-CREATION
> src/site/xdoc/faq.xml PRE-CREATION
> src/site/xdoc/implementation.xml PRE-CREATION
> src/site/xdoc/index.xml 47fd8f5876a92e00815923c20137028072765f70
> src/site/xdoc/intro.xml PRE-CREATION
> src/site/xdoc/io.xml 76f610b1633dec77be06c28bae03bc24c4a83a9e
>
> Diff: https://reviews.apache.org/r/10960/diff/
>
>
> Testing
> -------
>
> Built the site. Available at http://people.apache.org/~aching/GIRAPH-621/index.html
> Passed 'mvn clean verify'
>
>
> Thanks,
>
> Avery Ching
>
>
Re: Review Request: GIRAPH-621
Posted by Avery Ching <av...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10960/
-----------------------------------------------------------
(Updated May 6, 2013, 10:04 p.m.)
Review request for giraph.
Changes
-------
Addressed Maja's comments.
Description
-------
Add an introduction to Giraph to User Docs. Simplify the main landing page.
This addresses bug GIRAPH-621.
https://issues.apache.org/jira/browse/GIRAPH-621
Diffs (updated)
-----
src/site/resources/images/ExampleSSSP.svg PRE-CREATION
src/site/site.xml 695677258ffbc32d66e196986d83f66480ee2d0e
src/site/xdoc/build.xml PRE-CREATION
src/site/xdoc/faq.xml PRE-CREATION
src/site/xdoc/implementation.xml PRE-CREATION
src/site/xdoc/index.xml 47fd8f5876a92e00815923c20137028072765f70
src/site/xdoc/intro.xml PRE-CREATION
src/site/xdoc/io.xml 76f610b1633dec77be06c28bae03bc24c4a83a9e
Diff: https://reviews.apache.org/r/10960/diff/
Testing
-------
Built the site. Available at http://people.apache.org/~aching/GIRAPH-621/index.html
Passed 'mvn clean verify'
Thanks,
Avery Ching
Re: Review Request: GIRAPH-621
Posted by Avery Ching <av...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10960/
-----------------------------------------------------------
(Updated May 6, 2013, 9:22 p.m.)
Review request for giraph.
Changes
-------
one typo
Description
-------
Add an introduction to Giraph to User Docs. Simplify the main landing page.
This addresses bug GIRAPH-621.
https://issues.apache.org/jira/browse/GIRAPH-621
Diffs (updated)
-----
src/site/resources/images/ExampleSSSP.svg PRE-CREATION
src/site/site.xml 695677258ffbc32d66e196986d83f66480ee2d0e
src/site/xdoc/build.xml PRE-CREATION
src/site/xdoc/implementation.xml PRE-CREATION
src/site/xdoc/index.xml 47fd8f5876a92e00815923c20137028072765f70
src/site/xdoc/intro.xml PRE-CREATION
src/site/xdoc/io.xml 76f610b1633dec77be06c28bae03bc24c4a83a9e
Diff: https://reviews.apache.org/r/10960/diff/
Testing
-------
Built the site. Available at http://people.apache.org/~aching/GIRAPH-621/index.html
Passed 'mvn clean verify'
Thanks,
Avery Ching
Re: Review Request: GIRAPH-621
Posted by Avery Ching <av...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10960/
-----------------------------------------------------------
(Updated May 6, 2013, 9:19 p.m.)
Review request for giraph.
Description
-------
Add an introduction to Giraph to User Docs. Simplify the main landing page.
This addresses bug GIRAPH-621.
https://issues.apache.org/jira/browse/GIRAPH-621
Diffs
-----
src/site/resources/images/ExampleSSSP.svg PRE-CREATION
src/site/site.xml 695677258ffbc32d66e196986d83f66480ee2d0e
src/site/xdoc/build.xml PRE-CREATION
src/site/xdoc/implementation.xml PRE-CREATION
src/site/xdoc/index.xml 47fd8f5876a92e00815923c20137028072765f70
src/site/xdoc/intro.xml PRE-CREATION
src/site/xdoc/io.xml 76f610b1633dec77be06c28bae03bc24c4a83a9e
Diff: https://reviews.apache.org/r/10960/diff/
Testing
-------
Built the site. Available at http://people.apache.org/~aching/GIRAPH-621/index.html
Passed 'mvn clean verify'
Thanks,
Avery Ching