[GitHub] [nifi] ijokarumawak commented on issue #3351: NIFI-2933 Remote input/output ports at any PG

[GitBox <gi...@apache.org>]

ijokarumawak commented on issue #3351: NIFI-2933 Remote input/output ports at any PG
URL: https://github.com/apache/nifi/pull/3351#issuecomment-478526232
 
 
   @andrewmlim I checked other dialogs and found that:
   - Connection configuration dialog closes regardless of the result code. Even closes the dialog 400. Probably we should update this to provide consistent UX.
   - Processor / RPG dialog closes with only successful 200. All dialogs should follow this.
   
   I was confused with the current implementation of the Port configuration dialog. 
   Currently (before this PR), [Port config dialog source code](https://github.com/apache/nifi/blob/master/nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-ui/src/main/webapp/js/nf/canvas/nf-port-configuration.js#L125) has following comments and closes dialog when it receives non-successful response codes other than 400.
   ```java
   // handle bad request locally to keep the dialog open, allowing the user
   // to make changes. if the request fails for another reason, the dialog
   // should be closed so the issue can be addressed (stale flow for instance)
   ```
   
   On the other hand, RemoteProcessGroup (or Processor for example) configuration dialog does NOT close with status code such as 400 (bad request), 403 (forbidden) or 409 (conflict). It closes the dialog [with only 200 (success) response](https://github.com/apache/nifi/blob/master/nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-ui/src/main/webapp/js/nf/canvas/nf-remote-process-group-configuration.js#L113
   ).
   
   I think we should follow RemoteProcessGroup dialog style. Close the dialog only it receives 200. This PR already does so.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services