[GitHub] [trafficcontrol] ocket8888 commented on a change in pull request #4287: Clarify dev setup for Traffic Portal

[GitBox <gi...@apache.org>]

ocket8888 commented on a change in pull request #4287: Clarify dev setup for Traffic Portal
URL: https://github.com/apache/trafficcontrol/pull/4287#discussion_r365899588
 
 

 ##########
 File path: docs/source/development/traffic_portal.rst
 ##########
 @@ -45,5 +45,9 @@ Installing The Traffic Portal Developer Environment
 #. Run ``npm install`` to install application dependencies into ``traffic_portal/node_modules``. Only needs to be done the first time unless ``traffic_portal/package.json`` changes.
 #. Run ``bower install`` to install client-side dependencies into ``traffic_portal/app/bower_components``. Only needs to be done the first time unless ``traffic_portal/bower.json`` changes.
 #. Run ``grunt`` to package the application into ``traffic_portal/app/dist``, start a local HTTPS server (Express), and start a file watcher.
-#. Valid SSL certificates and keys are needed for Traffic Portal to run. Generate these (e.g. using `this SuperUser answer <https://superuser.com/questions/226192/avoid-password-prompt-for-keys-and-prompts-for-dn-information#answer-226229>`_) and edit the ``traffic_portal/conf/config.js`` file to reflect their names and locations
+#. Modify ``traffic_portal/conf/config.js``:
+  #. Valid SSL certificates and keys are needed for Traffic Portal to run. Generate these (e.g. using `this SuperUser answer <https://superuser.com/questions/226192/avoid-password-prompt-for-keys-and-prompts-for-dn-information#answer-226229>`_) and update ``ssl``.
 
 Review comment:
   missing a blank line between the end of the list and the beginning of the sublist:
   ```
   docs/source/development/traffic_portal.rst:49: WARNING: Enumerated list ends without a blank line; unexpected unindent.
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services