[GitHub] [calcite] laurentgo commented on a change in pull request #2531: [CALCITE-4787] Replace ImmutableBeans with Immutables

[GitBox <gi...@apache.org>]

laurentgo commented on a change in pull request #2531:
URL: https://github.com/apache/calcite/pull/2531#discussion_r712712042



##########
File path: core/build.gradle.kts
##########
@@ -61,6 +61,8 @@ dependencies {
     implementation("commons-io:commons-io")
     implementation("org.codehaus.janino:commons-compiler")
     implementation("org.codehaus.janino:janino")
+    annotationProcessor("org.immutables:value:2.8.2")

Review comment:
       Although, website still mentions 2.8.2, the latest release according to Maven Central and Github is 2.8.8 (with 2.9.0 being rc'ed)

##########
File path: core/src/main/java/org/apache/calcite/sql/pretty/SqlPrettyWriter.java
##########
@@ -360,7 +353,7 @@ public SqlPrettyWriter() {
 
   /** Creates a {@link SqlWriterConfig} with Calcite's SQL dialect. */
   public static SqlWriterConfig config() {
-    return CONFIG;
+    return SqlWriterConfig.of().withDialect(CalciteSqlDialect.DEFAULT);

Review comment:
       I guess this is a slight change of behavior as this is not a constant but a new instance each time?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org