You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by "lucasssvaz (via GitHub)" <gi...@apache.org> on 2023/01/31 14:31:41 UTC
[GitHub] [nuttx] lucasssvaz opened a new pull request, #8382: arch/xtensa/esp32: Propagate RTC IRQ status register to lower levels
lucasssvaz opened a new pull request, #8382:
URL: https://github.com/apache/nuttx/pull/8382
## Summary
This PR aims to fix a potential problem with the execution of 2nd level RTC IRQ handlers.
Some drivers might need to re-check the RTC status register. This patch propagates the current status register inside the interruption context.
## Impact
Nothing is affected by this currently.
Avoids possible problems that might occur in the future.
## Testing
Tested using the `esp32-lyrat:buttons` defconfig.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] xiaoxiang781216 merged pull request #8382: arch/xtensa/esp32: Propagate RTC IRQ status register to lower levels
Posted by "xiaoxiang781216 (via GitHub)" <gi...@apache.org>.
xiaoxiang781216 merged PR #8382:
URL: https://github.com/apache/nuttx/pull/8382
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] gustavonihei commented on a diff in pull request #8382: arch/xtensa/esp32: Propagate RTC IRQ status register to lower levels
Posted by "gustavonihei (via GitHub)" <gi...@apache.org>.
gustavonihei commented on code in PR #8382:
URL: https://github.com/apache/nuttx/pull/8382#discussion_r1092034976
##########
arch/xtensa/src/esp32/esp32_rtc_gpio.c:
##########
@@ -127,8 +128,9 @@ static inline bool is_valid_rtc_gpio(uint32_t rtcio_num)
****************************************************************************/
#ifdef CONFIG_ESP32_RTCIO_IRQ
-static void rtcio_dispatch(int irq, uint32_t status, uint32_t *context)
+static void rtcio_dispatch(int irq, uint32_t *reg_status)
Review Comment:
"Input Parameters" section in function documentation needs to be updated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] lucasssvaz commented on a diff in pull request #8382: arch/xtensa/esp32: Propagate RTC IRQ status register to lower levels
Posted by "lucasssvaz (via GitHub)" <gi...@apache.org>.
lucasssvaz commented on code in PR #8382:
URL: https://github.com/apache/nuttx/pull/8382#discussion_r1092039179
##########
arch/xtensa/src/esp32/esp32_rtc_gpio.c:
##########
@@ -127,8 +128,9 @@ static inline bool is_valid_rtc_gpio(uint32_t rtcio_num)
****************************************************************************/
#ifdef CONFIG_ESP32_RTCIO_IRQ
-static void rtcio_dispatch(int irq, uint32_t status, uint32_t *context)
+static void rtcio_dispatch(int irq, uint32_t *reg_status)
Review Comment:
Oh yes, I forgot about it. Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org