You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by "zzzk1 (via GitHub)" <gi...@apache.org> on 2023/12/07 15:15:18 UTC

[PR] [Improvement-15183][api] remove ApiException annotation #15276 [dolphinscheduler]

zzzk1 opened a new pull request, #15291:
URL: https://github.com/apache/dolphinscheduler/pull/15291

   <!--Thanks very much for contributing to Apache DolphinScheduler, we are happy that you want to help us improve DolphinScheduler! -->
   
   ## Purpose of the pull request
   
   <!--(For example: This pull request adds checkstyle plugin).-->
   the **@ApiException** is no need
   this pull request slove https://github.com/apache/dolphinscheduler/issues/15183
   
   ## Brief change log
   
   - change **org/apache/dolphinscheduler/api/exceptions** 
   - change **org/apache/dolphinscheduler/api/controller**  
   - change **org/apache/dolphinscheduler/api/controller/v2**
   - change **test/org/apache/dolphinscheduler/api/exceptions**
   ## Verify this pull request
   
   <!--*(Please pick either of the following options)*-->
   
   This pull request is already covered by existing tests, such as **unit test**
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [Improvement-15183][api] remove ApiException annotation #15276 [dolphinscheduler]

Posted by "zzzk1 (via GitHub)" <gi...@apache.org>.
zzzk1 closed pull request #15291:  [Improvement-15183][api] remove ApiException annotation #15276 
URL: https://github.com/apache/dolphinscheduler/pull/15291


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [Improvement-15183][api] remove ApiException annotation #15276 [dolphinscheduler]

Posted by "ruanwenjun (via GitHub)" <gi...@apache.org>.
ruanwenjun commented on PR #15291:
URL: https://github.com/apache/dolphinscheduler/pull/15291#issuecomment-1859363346

   > ![screenshot-github com-2023 12 17-23_10_30](https://private-user-images.githubusercontent.com/36791902/291070932-c6bb6cab-ce81-41be-b506-82a3ebaa7b85.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTEiLCJleHAiOjE3MDI4NjA4MjksIm5iZiI6MTcwMjg2MDUyOSwicGF0aCI6Ii8zNjc5MTkwMi8yOTEwNzA5MzItYzZiYjZjYWItY2U4MS00MWJlLWI1MDYtODJhM2ViYWE3Yjg1LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFJV05KWUFYNENTVkVINTNBJTJGMjAyMzEyMTglMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjMxMjE4VDAwNDg0OVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWU5NGMzNjkzOTY1Zjg2OGIwMWI3NjQyNTEzYTA4ZTNmMmU4OWUwZjM4NGQzZjQ0YWZmMWU1MzcwMTAyMDBkMDQmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.YhNfo0yPmt-Yg8KooVBGHbo3w5PgUbNSxUK4SMhUeWM)
   > @ruanwenjun These are test cases for **@ApiException** that I think can be removed
   
   Yes, we can remove this test case.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [Improvement-15183][api] remove ApiException annotation #15276 [dolphinscheduler]

Posted by "kezhenxu94 (via GitHub)" <gi...@apache.org>.
kezhenxu94 commented on PR #15291:
URL: https://github.com/apache/dolphinscheduler/pull/15291#issuecomment-1869007035

   Hi @zzzk1 , are you still working on this?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [Improvement-15183][api] remove ApiException annotation #15276 [dolphinscheduler]

Posted by "zzzk1 (via GitHub)" <gi...@apache.org>.
zzzk1 commented on PR #15291:
URL: https://github.com/apache/dolphinscheduler/pull/15291#issuecomment-1859199125

   ![screenshot-github com-2023 12 17-23_10_30](https://github.com/apache/dolphinscheduler/assets/36791902/c6bb6cab-ce81-41be-b506-82a3ebaa7b85)
   @ruanwenjun These are test cases for **@ApiException** that I think can be removed


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [Improvement-15183][api] remove ApiException annotation #15276 [dolphinscheduler]

Posted by "zzzk1 (via GitHub)" <gi...@apache.org>.
zzzk1 commented on PR #15291:
URL: https://github.com/apache/dolphinscheduler/pull/15291#issuecomment-1869010432

   > Hi @zzzk1 , are you still working on this?
   
   yes


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org