You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@samza.apache.org by GitBox <gi...@apache.org> on 2019/06/26 16:59:54 UTC

[GitHub] [samza] rmatharu commented on a change in pull request #1078: SAMZA-2248: Fix AM bookkeeping on receiving dead container notifications

rmatharu commented on a change in pull request #1078: SAMZA-2248: Fix AM bookkeeping on receiving dead container notifications
URL: https://github.com/apache/samza/pull/1078#discussion_r297771297
 
 

 ##########
 File path: samza-core/src/test/java/org/apache/samza/clustermanager/TestContainerRequestState.java
 ##########
 @@ -193,4 +193,28 @@ public void testContainerAssignment() throws Exception {
 
   }
 
+  @Test
 
 Review comment:
   Could we also add a test for this in TestContainerAllocator and/or TestHostAwareContainerAllocator?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services