[GitHub] [cloudstack] RodrigoDLopez commented on a change in pull request #4586: Externalize kvm agent storage reboot configuration

[GitBox <gi...@apache.org>]

RodrigoDLopez commented on a change in pull request #4586:
URL: https://github.com/apache/cloudstack/pull/4586#discussion_r558347356



##########
File path: plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/KVMHAMonitor.java
##########
@@ -32,17 +33,23 @@
 import java.util.concurrent.ConcurrentHashMap;
 
 public class KVMHAMonitor extends KVMHABase implements Runnable {
+
     private static final Logger s_logger = Logger.getLogger(KVMHAMonitor.class);
-    private final Map<String, NfsStoragePool> _storagePool = new ConcurrentHashMap<String, NfsStoragePool>();
+    private final Map<String, NfsStoragePool> _storagePool = new ConcurrentHashMap<>();

Review comment:
       And if we start to normalize these variable names in this file?
   Removing these underscore at the start of any variable. at least where some changes were needed




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org