You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@jclouds.apache.org by Vikas Rangarajan <no...@github.com> on 2018/07/31 21:49:46 UTC
[jclouds/jclouds] JCLOUDS-1436: Add support for aws ec2 m5 instance
types (#1233)
You can view, comment on, or merge this pull request online at:
https://github.com/jclouds/jclouds/pull/1233
-- Commit Summary --
* JCLOUDS-1436: Add support for aws ec2 m5 instance types
-- File Changes --
M apis/ec2/src/main/java/org/jclouds/ec2/compute/domain/EC2HardwareBuilder.java (72)
M apis/ec2/src/main/java/org/jclouds/ec2/domain/InstanceType.java (72)
M providers/aws-ec2/src/main/java/org/jclouds/aws/ec2/compute/suppliers/AWSEC2HardwareSupplier.java (14)
-- Patch Links --
https://github.com/jclouds/jclouds/pull/1233.patch
https://github.com/jclouds/jclouds/pull/1233.diff
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1233
Re: [jclouds/jclouds] JCLOUDS-1436: Add support for aws ec2 m5
instance types (#1233)
Posted by Daniel Estévez <no...@github.com>.
danielestevez approved this pull request.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1233#pullrequestreview-142542476
Re: [jclouds/jclouds] JCLOUDS-1436: Add support for aws ec2 m5
instance types (#1233)
Posted by Daniel Estévez <no...@github.com>.
Closed #1233.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1233#event-1766308008
Re: [jclouds/jclouds] JCLOUDS-1436: Add support for aws ec2 m5
instance types (#1233)
Posted by Daniel Estévez <no...@github.com>.
Pushed to [2.1.x](http://git-wip-us.apache.org/repos/asf/jclouds/commit/e54312aa) and [master](http://git-wip-us.apache.org/repos/asf/jclouds/commit/cf672337) !!
Thanks @VRanga000 !!
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1233#issuecomment-409731274
Re: [jclouds/jclouds] JCLOUDS-1436: Add support for aws ec2 m5
instance types (#1233)
Posted by Daniel Estévez <no...@github.com>.
Sorry! Got it now.
Please review the checkstyle since it seems to be breaking the build
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1233#issuecomment-409394722
Re: [jclouds/jclouds] JCLOUDS-1436: Add support for aws ec2 m5
instance types (#1233)
Posted by Vikas Rangarajan <no...@github.com>.
@danielestevez thanks for the review.. no, this PR is for a different set of instance types (m5) than #1232 (c5)
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1233#issuecomment-409389750
Re: [jclouds/jclouds] JCLOUDS-1436: Add support for aws ec2 m5
instance types (#1233)
Posted by Vikas Rangarajan <no...@github.com>.
@VRanga000 pushed 1 commit.
97d37f7 fix: remove duplicate imports
--
You are receiving this because you are subscribed to this thread.
View it on GitHub:
https://github.com/jclouds/jclouds/pull/1233/files/9ef582d31af1ea284c6020f80f6463c1c51bb266..97d37f74fb693e5f5f79c444208fac6cfb35aea1
Re: [jclouds/jclouds] JCLOUDS-1436: Add support for aws ec2 m5
instance types (#1233)
Posted by Daniel Estévez <no...@github.com>.
Isn't this the same PR as https://github.com/jclouds/jclouds/pull/1232 but with wrong checkstyle?
If i'm right, could you please close this one?
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1233#issuecomment-409387225