You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@lucene.apache.org by rm...@apache.org on 2015/03/31 20:14:39 UTC
svn commit: r1670414 -
/lucene/dev/branches/lucene6271/lucene/test-framework/src/java/org/apache/lucene/index/BasePostingsFormatTestCase.java
Author: rmuir
Date: Tue Mar 31 18:14:39 2015
New Revision: 1670414
URL: http://svn.apache.org/r1670414
Log:
LUCENE-6271: change this nocommit to a TODO, actually we should test more possibilities since the codec might specialize
Modified:
lucene/dev/branches/lucene6271/lucene/test-framework/src/java/org/apache/lucene/index/BasePostingsFormatTestCase.java
Modified: lucene/dev/branches/lucene6271/lucene/test-framework/src/java/org/apache/lucene/index/BasePostingsFormatTestCase.java
URL: http://svn.apache.org/viewvc/lucene/dev/branches/lucene6271/lucene/test-framework/src/java/org/apache/lucene/index/BasePostingsFormatTestCase.java?rev=1670414&r1=1670413&r2=1670414&view=diff
==============================================================================
--- lucene/dev/branches/lucene6271/lucene/test-framework/src/java/org/apache/lucene/index/BasePostingsFormatTestCase.java (original)
+++ lucene/dev/branches/lucene6271/lucene/test-framework/src/java/org/apache/lucene/index/BasePostingsFormatTestCase.java Tue Mar 31 18:14:39 2015
@@ -1620,13 +1620,13 @@ public abstract class BasePostingsFormat
PostingsEnum docs = null;
while(termsEnum.next() != null) {
BytesRef term = termsEnum.term();
+ // TODO: also sometimes ask for payloads/offsets?
boolean noPositions = random().nextBoolean();
if (noPositions) {
docs = termsEnum.postings(null, docs, PostingsEnum.FREQS);
} else {
docs = termsEnum.postings(null, null, PostingsEnum.POSITIONS);
}
- // nocommit: can we remove the noPositions and always ask for positions here?
int docFreq = 0;
long totalTermFreq = 0;
while (docs.nextDoc() != PostingsEnum.NO_MORE_DOCS) {
@@ -1669,6 +1669,7 @@ public abstract class BasePostingsFormat
// Also test seeking the TermsEnum:
for(String term : termFreqs.keySet()) {
if (termsEnum.seekExact(new BytesRef(term))) {
+ // TODO: also sometimes ask for payloads/offsets?
boolean noPositions = random().nextBoolean();
if (noPositions) {
docs = termsEnum.postings(null, docs, PostingsEnum.FREQS);