You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/11/23 02:39:45 UTC
[GitHub] [airflow] tsingh2k15 opened a new pull request #19760: remove upper bound for MarkupSafe
tsingh2k15 opened a new pull request #19760:
URL: https://github.com/apache/airflow/pull/19760
Per discussion and guidance from https://github.com/apache/airflow/discussions/19753, opening this PR for review. Based on if all the tests pass, this could be reviewed further.
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/main/UPDATING.md).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk edited a comment on pull request #19760: remove upper bound for MarkupSafe
Posted by GitBox <gi...@apache.org>.
potiuk edited a comment on pull request #19760:
URL: https://github.com/apache/airflow/pull/19760#issuecomment-976390051
> Hmm, the answer seems to be no...?
We have a repeating problems with `test_manager.py` causing OOM in public runners as of a few days. I am looking at it now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #19760: remove upper bound for MarkupSafe
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #19760:
URL: https://github.com/apache/airflow/pull/19760#issuecomment-981973406
Nope. That was another issue fixed in main (pickle error in PythonVirtualenv).
Please rebase: @tsingh2k15 :
> This branch is 36 commits ahead, 30 commits behind apache:main.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] tsingh2k15 edited a comment on pull request #19760: remove upper bound for MarkupSafe
Posted by GitBox <gi...@apache.org>.
tsingh2k15 edited a comment on pull request #19760:
URL: https://github.com/apache/airflow/pull/19760#issuecomment-982068373
> (sorry I missed the comment - the `main` was only recently brought to "greeen" status.
Will open a new PR with latest from upstream. Opened a new PR, will monitor the run there. https://github.com/apache/airflow/pull/19881
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] uranusjr commented on pull request #19760: remove upper bound for MarkupSafe
Posted by GitBox <gi...@apache.org>.
uranusjr commented on pull request #19760:
URL: https://github.com/apache/airflow/pull/19760#issuecomment-976297996
Let’s see first if the test suite like this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] tsingh2k15 commented on pull request #19760: remove upper bound for MarkupSafe
Posted by GitBox <gi...@apache.org>.
tsingh2k15 commented on pull request #19760:
URL: https://github.com/apache/airflow/pull/19760#issuecomment-979310198
> Rebase to latest `main` please - all the "serious" test failures shoud be fixed.
Rebased to latest `main`. Thanks! I will monitor the tests as the workflow proceeds further.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #19760: remove upper bound for MarkupSafe
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #19760:
URL: https://github.com/apache/airflow/pull/19760#issuecomment-978352272
Rebase to latest `main` please - all the "serious" test failures shoud be fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] boring-cyborg[bot] commented on pull request #19760: remove upper bound for MarkupSafe
Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on pull request #19760:
URL: https://github.com/apache/airflow/pull/19760#issuecomment-976111628
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
Here are some useful points:
- Pay attention to the quality of your code (flake8, mypy and type annotations). Our [pre-commits]( https://github.com/apache/airflow/blob/main/STATIC_CODE_CHECKS.rst#prerequisites-for-pre-commit-hooks) will help you with that.
- In case of a new feature add useful documentation (in docstrings or in `docs/` directory). Adding a new operator? Check this short [guide](https://github.com/apache/airflow/blob/main/docs/apache-airflow/howto/custom-operator.rst) Consider adding an example DAG that shows how users should use it.
- Consider using [Breeze environment](https://github.com/apache/airflow/blob/main/BREEZE.rst) for testing locally, it’s a heavy docker but it ships with a working Airflow and a lot of integrations.
- Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
- Please follow [ASF Code of Conduct](https://www.apache.org/foundation/policies/conduct) for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
- Be sure to read the [Airflow Coding style]( https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#coding-style-and-best-practices).
Apache Airflow is a community-driven project and together we are making it better 🚀.
In case of doubts contact the developers at:
Mailing List: dev@airflow.apache.org
Slack: https://s.apache.org/airflow-slack
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] eladkal commented on pull request #19760: remove upper bound for MarkupSafe
Posted by GitBox <gi...@apache.org>.
eladkal commented on pull request #19760:
URL: https://github.com/apache/airflow/pull/19760#issuecomment-981968555
@potiuk isn't that the same case we had with sshtunnel and azure cosmos ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] tsingh2k15 commented on pull request #19760: remove upper bound for MarkupSafe
Posted by GitBox <gi...@apache.org>.
tsingh2k15 commented on pull request #19760:
URL: https://github.com/apache/airflow/pull/19760#issuecomment-982068373
> (sorry I missed the comment - the `main` was only recently brought to "greeen" status.
Will open a new PR with latest from upstream
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] tsingh2k15 commented on pull request #19760: remove upper bound for MarkupSafe
Posted by GitBox <gi...@apache.org>.
tsingh2k15 commented on pull request #19760:
URL: https://github.com/apache/airflow/pull/19760#issuecomment-976507273
> > Hmm, the answer seems to be no...?
>
> We have a repeating problems with `test_manager.py` causing OOM in public runners as of a few days. I am looking at it now.
Thanks for clarification! It would be helpful to learn more if there are risks and/or compatibility issues with this change. We can wait till all tests run.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #19760: remove upper bound for MarkupSafe
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #19760:
URL: https://github.com/apache/airflow/pull/19760#issuecomment-976390051
> Hmm, the answer seems to be no...?
We have a repeating problems with `test_manager.py` causing OOM in public runner as a few days. I am looking at it now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] tsingh2k15 closed pull request #19760: remove upper bound for MarkupSafe
Posted by GitBox <gi...@apache.org>.
tsingh2k15 closed pull request #19760:
URL: https://github.com/apache/airflow/pull/19760
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] uranusjr commented on pull request #19760: remove upper bound for MarkupSafe
Posted by GitBox <gi...@apache.org>.
uranusjr commented on pull request #19760:
URL: https://github.com/apache/airflow/pull/19760#issuecomment-976382020
Hmm, the answer seems to be no...?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk edited a comment on pull request #19760: remove upper bound for MarkupSafe
Posted by GitBox <gi...@apache.org>.
potiuk edited a comment on pull request #19760:
URL: https://github.com/apache/airflow/pull/19760#issuecomment-976390051
> Hmm, the answer seems to be no...?
We have a repeating problems with `test_manager.py` causing OOM in public runner as of a few days. I am looking at it now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #19760: remove upper bound for MarkupSafe
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #19760:
URL: https://github.com/apache/airflow/pull/19760#issuecomment-981974192
(sorry I missed the comment - the `main` was only recently brought to "greeen" status.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] tsingh2k15 commented on pull request #19760: remove upper bound for MarkupSafe
Posted by GitBox <gi...@apache.org>.
tsingh2k15 commented on pull request #19760:
URL: https://github.com/apache/airflow/pull/19760#issuecomment-979367104
> > Rebase to latest `main` please - all the "serious" test failures shoud be fixed.
>
> Rebased to latest `main`. Thanks! I will monitor the tests as the workflow proceeds further.
@potiuk It looks like the tests are failing while validating constraints. Trying to understand the failures. It seems like tests are comparing the dependencies with https://raw.githubusercontent.com/apache/airflow/constraints-main/constraints-source-providers-3.7.txt. Your input here would be helpful. Thanks! Below is the snippet from one of the test failures.
```
***********************************************************************************************
***********************************************************************************************
*
* In case you see unrelated test failures, it can be due to newer dependencies released.
* This is either because it is 'main' branch or because this PR modifies dependencies (setup.* files).
* Therefore 'eager-upgrade' is used to build the image, This means that this build can have newer dependencies than the 'tested' set of constraints,
*
* The tested constraints for that build are available at: https://raw.githubusercontent.com/apache/airflow/constraints-main/constraints-source-providers-3.7.txt
*
* Please double check if the same failure is in other tests and in 'main' branch and check if the dependency differences causes the problem.
* In case you identify the dependency, either fix the root cause or limit the dependency if it is too difficult to fix.
*
* The diff between fixed constraints and those used in this build is below.
*
***********************************************************************************************
% Total % Received % Xferd Average Speed Time Time Time Current
Dload Upload Total Spent Left Speed
0 0 0 0 0 0 0 0 --:--:-- --:--:-- --:--:-- 0
100 9958 100 9958 0 0 81622 0 --:--:-- --:--:-- --:--:-- 81622
19c19
< Jinja2==2.11.3
---
> Jinja2==3.0.3
22c22
< MarkupSafe==1.1.1
---
> MarkupSafe==2.0.1
107c107
< charset-normalizer==2.0.7
---
> charset-normalizer==2.0.8
242c242
< keyring==23.2.1
---
> keyring==23.3.0
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org