You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hbase.apache.org by "Duo Zhang (Jira)" <ji...@apache.org> on 2022/04/09 15:56:00 UTC
[jira] [Resolved] (HBASE-26922) Fix LineLength warnings as much as possible if it can not be fixed by spotless
[ https://issues.apache.org/jira/browse/HBASE-26922?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Duo Zhang resolved HBASE-26922.
-------------------------------
Fix Version/s: 2.5.0
3.0.0-alpha-3
2.4.12
Hadoop Flags: Reviewed
Resolution: Fixed
Pushed to branch-2.4+.
Thanks [~niuyulin] for reviewing!
> Fix LineLength warnings as much as possible if it can not be fixed by spotless
> ------------------------------------------------------------------------------
>
> Key: HBASE-26922
> URL: https://issues.apache.org/jira/browse/HBASE-26922
> Project: HBase
> Issue Type: Sub-task
> Reporter: Duo Zhang
> Assignee: Duo Zhang
> Priority: Major
> Fix For: 2.5.0, 3.0.0-alpha-3, 2.4.12
>
>
> One possible problem is the trailing comment, Like this
> {code}
> assertTrue(initialRegions
> .contains(RegionReplicaUtil.getRegionInfoForReplica(mergedRegions.getFirst(), 1))); // this
> // is
> // the
> // replica
> // of
> // the
> // first
> // region
> {code}
> Because of we limited line length, the format will be very strange and still has line length problem if some of the words are too long.
> Let's move them from trailing to top of the statement.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)