You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@bookkeeper.apache.org by GitBox <gi...@apache.org> on 2022/09/09 04:20:00 UTC
[GitHub] [bookkeeper] zymap opened a new pull request, #3480: Fix the deadlock when only using io thread to handle request
zymap opened a new pull request, #3480:
URL: https://github.com/apache/bookkeeper/pull/3480
---
*Motivation*
If the user doesn't configure the ReadWorker thread pool, the request will process with io thread. We cannot call await() from an IO thread, if the socket buffer is full, that blocking call would cause a deadlock.
*Modification*
- only wait for the promise when the thread is not io thread
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] hangc0276 commented on pull request #3480: Fix the deadlock when only using io thread to handle request
Posted by GitBox <gi...@apache.org>.
hangc0276 commented on PR #3480:
URL: https://github.com/apache/bookkeeper/pull/3480#issuecomment-1241496814
Nice catch!
Please fix the check style.
```
Error: /home/runner/work/bookkeeper/bookkeeper/bookkeeper-server/src/main/java/org/apache/bookkeeper/proto/PacketProcessorBase.java:22:1: Import io.netty.channel.ChannelFuture appears after other imports that it should precede [ImportOrder]
Error: /home/runner/work/bookkeeper/bookkeeper/bookkeeper-server/src/test/java/org/apache/bookkeeper/client/BookieRecoveryUseIOThreadTest.java:26:1: Extra separation in import group before 'java.io.IOException' [ImportOrder]
Error: /home/runner/work/bookkeeper/bookkeeper/bookkeeper-server/src/test/java/org/apache/bookkeeper/client/BookieRecoveryUseIOThreadTest.java:26:1: Import java.io.IOException appears after other imports that it should precede [ImportOrder]
Audit done.
[INFO] There are 3 errors reported by Checkstyle 9.3 with buildtools/src/main/resources/bookkeeper/checkstyle.xml ruleset.
Error: src/main/java/org/apache/bookkeeper/proto/PacketProcessorBase.java:[22,1] (imports) ImportOrder: Import io.netty.channel.ChannelFuture appears after other imports that it should precede
Error: src/test/java/org/apache/bookkeeper/client/BookieRecoveryUseIOThreadTest.java:[26,1] (imports) ImportOrder: Extra separation in import group before 'java.io.IOException'
Error: src/test/java/org/apache/bookkeeper/client/BookieRecoveryUseIOThreadTest.java:[26,1] (imports) ImportOrder: Import java.io.IOException appears after other imports that it should precede
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] eolivelli merged pull request #3480: Fix the deadlock when only using io thread to handle request
Posted by GitBox <gi...@apache.org>.
eolivelli merged PR #3480:
URL: https://github.com/apache/bookkeeper/pull/3480
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org