You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Johan Oskarsson (JIRA)" <ji...@apache.org> on 2009/03/31 12:19:50 UTC
[jira] Created: (CASSANDRA-26) Move source into src/java
Move source into src/java
-------------------------
Key: CASSANDRA-26
URL: https://issues.apache.org/jira/browse/CASSANDRA-26
Project: Cassandra
Issue Type: Improvement
Reporter: Johan Oskarsson
In order to allow code in different languages I suggest we move the current src/* into src/java and test/* into test/java.
Perhaps one day we would like to publish easy to use client libs in other languages or put test configuration in test/conf as in CASSANDRA-22, this move would help make such changes easier before we have too many outstanding patches against the current source.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-26) Move source into src/java
Posted by "Johan Oskarsson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-26?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12694120#action_12694120 ]
Johan Oskarsson commented on CASSANDRA-26:
------------------------------------------
Agreed that the client libs might live somewhere else, but I would still argue there is a case for src/java, for example if we implement native compression libraries, src/native or src/c++ for example.
> Move source into src/java
> -------------------------
>
> Key: CASSANDRA-26
> URL: https://issues.apache.org/jira/browse/CASSANDRA-26
> Project: Cassandra
> Issue Type: Improvement
> Reporter: Johan Oskarsson
>
> In order to allow code in different languages I suggest we move the current src/* into src/java and test/* into test/java.
> Perhaps one day we would like to publish easy to use client libs in other languages or put test configuration in test/conf as in CASSANDRA-22, this move would help make such changes easier before we have too many outstanding patches against the current source.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-26) Move source into src/java
Posted by "Johan Oskarsson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-26?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12695488#action_12695488 ]
Johan Oskarsson commented on CASSANDRA-26:
------------------------------------------
Going to make another push for this. Right now we generate code into src, meaning if someone is reviewing a patch or coding on a new one it's hard to know which files are generated or coded. Moving all generated code into something like src/gen-java and the other into src/java would resolve this.
> Move source into src/java
> -------------------------
>
> Key: CASSANDRA-26
> URL: https://issues.apache.org/jira/browse/CASSANDRA-26
> Project: Cassandra
> Issue Type: Improvement
> Reporter: Johan Oskarsson
> Assignee: Avinash Lakshman
>
> In order to allow code in different languages I suggest we move the current src/* into src/java and test/* into test/java.
> Perhaps one day we would like to publish easy to use client libs in other languages or put test configuration in test/conf as in CASSANDRA-22, this move would help make such changes easier before we have too many outstanding patches against the current source.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-26) Move source into src/java
Posted by "Sandeep Tata (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-26?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12695491#action_12695491 ]
Sandeep Tata commented on CASSANDRA-26:
---------------------------------------
+1
I'd rather not have ANTLR and others generating code into the same (src/java) directories.
> Move source into src/java
> -------------------------
>
> Key: CASSANDRA-26
> URL: https://issues.apache.org/jira/browse/CASSANDRA-26
> Project: Cassandra
> Issue Type: Improvement
> Reporter: Johan Oskarsson
> Assignee: Avinash Lakshman
>
> In order to allow code in different languages I suggest we move the current src/* into src/java and test/* into test/java.
> Perhaps one day we would like to publish easy to use client libs in other languages or put test configuration in test/conf as in CASSANDRA-22, this move would help make such changes easier before we have too many outstanding patches against the current source.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-26) Move source into src/java
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-26?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12694110#action_12694110 ]
Jonathan Ellis commented on CASSANDRA-26:
-----------------------------------------
+1 moving test/ but I don't think client code should go under src/ anyway. contrib/ or client/ or client-src/ maybe.
is that reasonable?
> Move source into src/java
> -------------------------
>
> Key: CASSANDRA-26
> URL: https://issues.apache.org/jira/browse/CASSANDRA-26
> Project: Cassandra
> Issue Type: Improvement
> Reporter: Johan Oskarsson
>
> In order to allow code in different languages I suggest we move the current src/* into src/java and test/* into test/java.
> Perhaps one day we would like to publish easy to use client libs in other languages or put test configuration in test/conf as in CASSANDRA-22, this move would help make such changes easier before we have too many outstanding patches against the current source.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-26) Move source into src/java
Posted by "Johan Oskarsson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-26?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12694149#action_12694149 ]
Johan Oskarsson commented on CASSANDRA-26:
------------------------------------------
It's going to be considerably more painful to change further down the line when people have uncommitted patches.
> Move source into src/java
> -------------------------
>
> Key: CASSANDRA-26
> URL: https://issues.apache.org/jira/browse/CASSANDRA-26
> Project: Cassandra
> Issue Type: Improvement
> Reporter: Johan Oskarsson
>
> In order to allow code in different languages I suggest we move the current src/* into src/java and test/* into test/java.
> Perhaps one day we would like to publish easy to use client libs in other languages or put test configuration in test/conf as in CASSANDRA-22, this move would help make such changes easier before we have too many outstanding patches against the current source.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (CASSANDRA-26) Move source into src/java
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-26?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Ellis resolved CASSANDRA-26.
-------------------------------------
Resolution: Fixed
Assignee: Jonathan Ellis (was: Avinash Lakshman)
> Move source into src/java
> -------------------------
>
> Key: CASSANDRA-26
> URL: https://issues.apache.org/jira/browse/CASSANDRA-26
> Project: Cassandra
> Issue Type: Improvement
> Reporter: Johan Oskarsson
> Assignee: Jonathan Ellis
> Attachments: CASSANDRA-26.patch, CASSANDRA-26.sh
>
>
> In order to allow code in different languages I suggest we move the current src/* into src/java and test/* into test/java.
> Perhaps one day we would like to publish easy to use client libs in other languages or put test configuration in test/conf as in CASSANDRA-22, this move would help make such changes easier before we have too many outstanding patches against the current source.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-26) Move source into src/java
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-26?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12694135#action_12694135 ]
Jonathan Ellis commented on CASSANDRA-26:
-----------------------------------------
until then I would say it is a case of YAGNI :)
> Move source into src/java
> -------------------------
>
> Key: CASSANDRA-26
> URL: https://issues.apache.org/jira/browse/CASSANDRA-26
> Project: Cassandra
> Issue Type: Improvement
> Reporter: Johan Oskarsson
>
> In order to allow code in different languages I suggest we move the current src/* into src/java and test/* into test/java.
> Perhaps one day we would like to publish easy to use client libs in other languages or put test configuration in test/conf as in CASSANDRA-22, this move would help make such changes easier before we have too many outstanding patches against the current source.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CASSANDRA-26) Move source into src/java
Posted by "Johan Oskarsson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-26?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Johan Oskarsson updated CASSANDRA-26:
-------------------------------------
Attachment: CASSANDRA-26.sh
CASSANDRA-26.patch
Moves the source directories as mentioned. Run shell script to move, apply patch to update the build.xml
> Move source into src/java
> -------------------------
>
> Key: CASSANDRA-26
> URL: https://issues.apache.org/jira/browse/CASSANDRA-26
> Project: Cassandra
> Issue Type: Improvement
> Reporter: Johan Oskarsson
> Assignee: Avinash Lakshman
> Attachments: CASSANDRA-26.patch, CASSANDRA-26.sh
>
>
> In order to allow code in different languages I suggest we move the current src/* into src/java and test/* into test/java.
> Perhaps one day we would like to publish easy to use client libs in other languages or put test configuration in test/conf as in CASSANDRA-22, this move would help make such changes easier before we have too many outstanding patches against the current source.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (CASSANDRA-26) Move source into src/java
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-26?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Ellis reassigned CASSANDRA-26:
---------------------------------------
Assignee: Avinash Lakshman
I'm going to assign this to Avinash since I know he has uncommitted changes. If he wants to do a mv after committing, great. But I am not going to push for it.
> Move source into src/java
> -------------------------
>
> Key: CASSANDRA-26
> URL: https://issues.apache.org/jira/browse/CASSANDRA-26
> Project: Cassandra
> Issue Type: Improvement
> Reporter: Johan Oskarsson
> Assignee: Avinash Lakshman
>
> In order to allow code in different languages I suggest we move the current src/* into src/java and test/* into test/java.
> Perhaps one day we would like to publish easy to use client libs in other languages or put test configuration in test/conf as in CASSANDRA-22, this move would help make such changes easier before we have too many outstanding patches against the current source.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.