You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2020/03/20 15:42:02 UTC
[GitHub] [pulsar-client-ruby] lukfugl opened a new pull request #1: Reader
interface
lukfugl opened a new pull request #1: Reader interface
URL: https://github.com/apache/pulsar-client-ruby/pull/1
Adds reader interface alongside producer and consumer.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [pulsar-client-ruby] addisonj commented on a change in pull request
#1: Reader interface
Posted by GitBox <gi...@apache.org>.
addisonj commented on a change in pull request #1: Reader interface
URL: https://github.com/apache/pulsar-client-ruby/pull/1#discussion_r395727826
##########
File path: README.md
##########
@@ -1 +1,114 @@
# Apache Pulsar Ruby client
+
Review comment:
I think it would be really useful to put just a broad checklist of the status of this as far as features, for example, let's call out that batch publishing and batch ack don't work yet.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [pulsar-client-ruby] addisonj commented on a change in pull request
#1: Reader interface
Posted by GitBox <gi...@apache.org>.
addisonj commented on a change in pull request #1: Reader interface
URL: https://github.com/apache/pulsar-client-ruby/pull/1#discussion_r395728858
##########
File path: TODO.md
##########
@@ -0,0 +1,24 @@
+# Confirm Licensing and Copyright
Review comment:
Oh didn't see this file before. Some of this is specific to us, so we might want to strip it out? If we want to keep this file as the current state of the project, we should point the README at this file
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services