You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by "Gilthoniel (via GitHub)" <gi...@apache.org> on 2024/07/26 11:24:55 UTC

[PR] [Issue 1259][producer] Prevent panic when calling Flush on closed producer [pulsar-client-go]

Gilthoniel opened a new pull request, #1260:
URL: https://github.com/apache/pulsar-client-go/pull/1260

   Fixes #1259 
   
   ### Motivation
   
   When calling Flush or FlushWithCtx after closing the producer, it will panic.
   
   ### Modifications
   
   Check the state of the producer before proceeding with a flush and return an error if it is closed already.
   
   ### Verifying this change
   
   - [x] Make sure that the change passes the CI checks.
   
   This change added tests and can be verified as follows:
   - *Added integration test to call FlushWithCtx after Close and see that it returns an error*
   
   ### Does this pull request potentially affect one of the following parts:
   
   None
   
   ### Documentation
   
     - Does this pull request introduce a new feature? no
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [Issue 1259][producer] Prevent panic when calling Flush on closed producer [pulsar-client-go]

Posted by "crossoverJie (via GitHub)" <gi...@apache.org>.
crossoverJie merged PR #1260:
URL: https://github.com/apache/pulsar-client-go/pull/1260


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org