You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/08/19 03:12:54 UTC
[GitHub] [arrow-datafusion-python] francis-du opened a new issue, #38: Rust Release 1.63.0 add a new lint `borrow_deref_ref` causing Cargo Clippy error
francis-du opened a new issue, #38:
URL: https://github.com/apache/arrow-datafusion-python/issues/38
https://rust-lang.github.io/rust-clippy/master/index.html#borrow_deref_ref
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion-python] andygrove commented on issue #38: Rust Release 1.63.0 add a new lint `borrow_deref_ref` causing Cargo Clippy error
Posted by GitBox <gi...@apache.org>.
andygrove commented on issue #38:
URL: https://github.com/apache/arrow-datafusion-python/issues/38#issuecomment-1222422593
Should be fixed when pyo3 0.17 is released. The issue is already fixed in their repo. See https://github.com/PyO3/pyo3/issues/2555
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion-python] francis-du commented on issue #38: Rust Release 1.63.0 add a new lint `borrow_deref_ref` causing Cargo Clippy error
Posted by GitBox <gi...@apache.org>.
francis-du commented on issue #38:
URL: https://github.com/apache/arrow-datafusion-python/issues/38#issuecomment-1223465659
Should we fix it by updating pyo3 or by modifying the parameter type?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion-python] andygrove commented on issue #38: Rust Release 1.63.0 add a new lint `borrow_deref_ref` causing Cargo Clippy error
Posted by GitBox <gi...@apache.org>.
andygrove commented on issue #38:
URL: https://github.com/apache/arrow-datafusion-python/issues/38#issuecomment-1222423292
The other option is to use `String` instead of `&str` for arguments in python methods.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion-python] francis-du closed issue #38: Rust Release 1.63.0 add a new lint `borrow_deref_ref` causing Cargo Clippy error
Posted by GitBox <gi...@apache.org>.
francis-du closed issue #38: Rust Release 1.63.0 add a new lint `borrow_deref_ref` causing Cargo Clippy error
URL: https://github.com/apache/arrow-datafusion-python/issues/38
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion-python] andygrove commented on issue #38: Rust Release 1.63.0 add a new lint `borrow_deref_ref` causing Cargo Clippy error
Posted by GitBox <gi...@apache.org>.
andygrove commented on issue #38:
URL: https://github.com/apache/arrow-datafusion-python/issues/38#issuecomment-1225718831
pyo3 0.17 is now available but we have to update in arrow-rs and then arrow-datafusion and wait for a new release before we can update here.
IMO, changing the signature for now would be quicker and we can change it back later.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org