You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2020/12/10 13:22:38 UTC

[GitHub] [apisix-dashboard] nic-chen commented on pull request #994: feat: add access log for Manager API

nic-chen commented on pull request #994:
URL: https://github.com/apache/apisix-dashboard/pull/994#issuecomment-742517813


   > > I think you need to add unit tests.
   > 
   > I think we should use E2E test here. @nic-chen please confirm
   
   
   This access log is for Manager API, does not involve DP, so e2e test should not be needed.
   
   I have added a simple unit test case to confirm that it will not cause errors.
    
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org