You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@systemds.apache.org by GitBox <gi...@apache.org> on 2021/02/02 16:08:35 UTC
[GitHub] [systemds] ywcb00 commented on a change in pull request #1175: [SYSTEMDS-2747] Federated PNMF Test
ywcb00 commented on a change in pull request #1175:
URL: https://github.com/apache/systemds/pull/1175#discussion_r568726593
##########
File path: src/main/java/org/apache/sysds/runtime/instructions/fed/QuaternaryWCeMMFEDInstruction.java
##########
@@ -59,17 +60,17 @@ public void processInstruction(ExecutionContext ec)
MatrixObject U = ec.getMatrixObject(input2);
MatrixObject V = ec.getMatrixObject(input3);
ScalarObject eps = null;
-
+
if(qop.hasFourInputs()) {
eps = (_input4.getDataType() == DataType.SCALAR) ?
ec.getScalarInput(_input4) :
new DoubleObject(ec.getMatrixInput(_input4.getName()).quickGetValue(0, 0));
}
- if(!(X.isFederated() && !U.isFederated() && !V.isFederated()))
+ if(!(X.isFederated(FType.ROW) && !U.isFederated() && !V.isFederated()))
Review comment:
I converted it to the positive case for all five federated quaternary operations.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org