You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Scott Lamb <sl...@slamb.org> on 2002/08/06 23:26:11 UTC
[PATCH] Move library version to svn_config.
Karl Fogel wrote:
> Yup. So we would make a separate SVN_VER_LIBRARY in svn_version.h,
> and parse it out for the build/install process, and also Scott's patch
> would use it?
[...]
> Scott, how would you feel about taking all of this on (i.e., extending
> your ra_loader patch to solve all of these problems)? Fine to say no,
> of course, just let us know so we can schedule it in that case.
Done. I haven't actually done a "make install" (no good machine handy)
but build-outputs.mk looks right and I can't imagine ra_loader.c being
wrong.
Question: why are the build.conf and build-outputs.mk filenames handled
the way they are? They're passed through several levels of Python code
but hardcoded in the end in gen-make.py or autogen.sh. I tried to match
it with the svn-version.h filename, but I confess I don't see the point.
--
Scott Lamb
Re: [PATCH] Move library version to svn_config.
Posted by Greg Stein <gs...@lyra.org>.
On Wed, Aug 07, 2002 at 07:41:07AM -0500, Scott Lamb wrote:
>...
> Yeah, that's what I'm referring to. gen-make.py hardcodes `basename
> $buildconf .conf`-outputs.mk and autogen.sh hardcodes build.conf. It
> just seemed funny that they were made mostly-configurable in
> gen-make.py, gen_base.py, and gen_make.py, when apparently no one uses
> it with anything other than build.conf. Not a huge deal.
When I first wrote it, I wanted to leave the gen-make.py tool /somewhat/
useful to other projects. Of course, when I got into the guts of it... it
really isn't all that project-portable (gen-make knows about the FS and
Apache and whatnot).
At this point, we could just say "screw it" and hardcode filenames into
gen-make.py. It is only a tiny stub over the build/ modules, so it isn't
like it is a bitch to simply replace it in the future.
Cheers,
-g
--
Greg Stein, http://www.lyra.org/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: [PATCH] Move library version to svn_config.
Posted by Scott Lamb <sl...@slamb.org>.
Greg Stein wrote:
> On Tue, Aug 06, 2002 at 06:26:11PM -0500, Scott Lamb wrote:
>>...
>>Question: why are the build.conf and build-outputs.mk filenames handled
>>the way they are? They're passed through several levels of Python code
>>but hardcoded in the end in gen-make.py or autogen.sh. I tried to match
>>it with the svn-version.h filename, but I confess I don't see the point.
>
> Hard-coded? gen-make.py only hardcodes the -outputs.mk suffix. Is that what
> you're referring to? As to why... well, why not? :-)
>
> autogen.sh has to hard-code something. It's the guy that gets the system set
> up. I don't see why it *shouldn't* hardcode build.conf.
>
> I gotta confess that I don't quite understand what you're driving at here.
>
> Cheers,
> -g
>
Yeah, that's what I'm referring to. gen-make.py hardcodes `basename
$buildconf .conf`-outputs.mk and autogen.sh hardcodes build.conf. It
just seemed funny that they were made mostly-configurable in
gen-make.py, gen_base.py, and gen_make.py, when apparently no one uses
it with anything other than build.conf. Not a huge deal.
--
Scott Lamb
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: [PATCH] Move library version to svn_config.
Posted by Greg Stein <gs...@lyra.org>.
On Tue, Aug 06, 2002 at 06:26:11PM -0500, Scott Lamb wrote:
>...
> Question: why are the build.conf and build-outputs.mk filenames handled
> the way they are? They're passed through several levels of Python code
> but hardcoded in the end in gen-make.py or autogen.sh. I tried to match
> it with the svn-version.h filename, but I confess I don't see the point.
Hard-coded? gen-make.py only hardcodes the -outputs.mk suffix. Is that what
you're referring to? As to why... well, why not? :-)
autogen.sh has to hard-code something. It's the guy that gets the system set
up. I don't see why it *shouldn't* hardcode build.conf.
I gotta confess that I don't quite understand what you're driving at here.
Cheers,
-g
--
Greg Stein, http://www.lyra.org/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org