You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/12/08 16:11:22 UTC
[GitHub] [flink] zentol opened a new pull request #14340: [FLINK-20533][datadog] Add Histogram support
zentol opened a new pull request #14340:
URL: https://github.com/apache/flink/pull/14340
Adds support for histograms to the datadog reporter, and does a bunch of cleanup work in the code.
Histograms are mapped to a series of gauges; while datadog does have a histogram metric type it is not supported via the HTTP API that we use.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zentol commented on pull request #14340: [FLINK-20533][datadog] Add Histogram support
Posted by GitBox <gi...@apache.org>.
zentol commented on pull request #14340:
URL: https://github.com/apache/flink/pull/14340#issuecomment-741151716
@flinkbot run azure
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14340: [FLINK-20533][datadog] Add Histogram support
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14340:
URL: https://github.com/apache/flink/pull/14340#issuecomment-740746774
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "4f62e23c4ec3c38a510b4d3eb93935c6972b7e7e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10667",
"triggerID" : "4f62e23c4ec3c38a510b4d3eb93935c6972b7e7e",
"triggerType" : "PUSH"
}, {
"hash" : "4f62e23c4ec3c38a510b4d3eb93935c6972b7e7e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10675",
"triggerID" : "741151716",
"triggerType" : "MANUAL"
}, {
"hash" : "4f62e23c4ec3c38a510b4d3eb93935c6972b7e7e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10667",
"triggerID" : "741151716",
"triggerType" : "MANUAL"
}, {
"hash" : "ccbb7ca839b16f8d587fbcc88cb42be1fee636fc",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10836",
"triggerID" : "ccbb7ca839b16f8d587fbcc88cb42be1fee636fc",
"triggerType" : "PUSH"
}, {
"hash" : "1618c8c9d6639b774ea6336b90a0c0b2ce888b80",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10837",
"triggerID" : "1618c8c9d6639b774ea6336b90a0c0b2ce888b80",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 1618c8c9d6639b774ea6336b90a0c0b2ce888b80 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10837)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14340: [FLINK-20533][datadog] Add Histogram support
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14340:
URL: https://github.com/apache/flink/pull/14340#issuecomment-740746774
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "4f62e23c4ec3c38a510b4d3eb93935c6972b7e7e",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10667",
"triggerID" : "4f62e23c4ec3c38a510b4d3eb93935c6972b7e7e",
"triggerType" : "PUSH"
}, {
"hash" : "4f62e23c4ec3c38a510b4d3eb93935c6972b7e7e",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10675",
"triggerID" : "741151716",
"triggerType" : "MANUAL"
}, {
"hash" : "4f62e23c4ec3c38a510b4d3eb93935c6972b7e7e",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10667",
"triggerID" : "741151716",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* 4f62e23c4ec3c38a510b4d3eb93935c6972b7e7e Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10675) Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10667)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14340: [FLINK-20533][datadog] Add Histogram support
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14340:
URL: https://github.com/apache/flink/pull/14340#issuecomment-740746774
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "4f62e23c4ec3c38a510b4d3eb93935c6972b7e7e",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10667",
"triggerID" : "4f62e23c4ec3c38a510b4d3eb93935c6972b7e7e",
"triggerType" : "PUSH"
}, {
"hash" : "4f62e23c4ec3c38a510b4d3eb93935c6972b7e7e",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10675",
"triggerID" : "741151716",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* 4f62e23c4ec3c38a510b4d3eb93935c6972b7e7e Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10667) Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10675)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #14340: [FLINK-20533][datadog] Add Histogram support
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #14340:
URL: https://github.com/apache/flink/pull/14340#issuecomment-740723124
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 4f62e23c4ec3c38a510b4d3eb93935c6972b7e7e (Tue Dec 08 16:14:17 UTC 2020)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14340: [FLINK-20533][datadog] Add Histogram support
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14340:
URL: https://github.com/apache/flink/pull/14340#issuecomment-740746774
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "4f62e23c4ec3c38a510b4d3eb93935c6972b7e7e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10667",
"triggerID" : "4f62e23c4ec3c38a510b4d3eb93935c6972b7e7e",
"triggerType" : "PUSH"
}, {
"hash" : "4f62e23c4ec3c38a510b4d3eb93935c6972b7e7e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10675",
"triggerID" : "741151716",
"triggerType" : "MANUAL"
}, {
"hash" : "4f62e23c4ec3c38a510b4d3eb93935c6972b7e7e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10667",
"triggerID" : "741151716",
"triggerType" : "MANUAL"
}, {
"hash" : "ccbb7ca839b16f8d587fbcc88cb42be1fee636fc",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10836",
"triggerID" : "ccbb7ca839b16f8d587fbcc88cb42be1fee636fc",
"triggerType" : "PUSH"
}, {
"hash" : "1618c8c9d6639b774ea6336b90a0c0b2ce888b80",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10837",
"triggerID" : "1618c8c9d6639b774ea6336b90a0c0b2ce888b80",
"triggerType" : "PUSH"
}, {
"hash" : "3dfcdba2dc6932632be7ef4391a03c7db3688b63",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10893",
"triggerID" : "3dfcdba2dc6932632be7ef4391a03c7db3688b63",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 1618c8c9d6639b774ea6336b90a0c0b2ce888b80 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10837)
* 3dfcdba2dc6932632be7ef4391a03c7db3688b63 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10893)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14340: [FLINK-20533][datadog] Add Histogram support
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14340:
URL: https://github.com/apache/flink/pull/14340#issuecomment-740746774
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "4f62e23c4ec3c38a510b4d3eb93935c6972b7e7e",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10667",
"triggerID" : "4f62e23c4ec3c38a510b4d3eb93935c6972b7e7e",
"triggerType" : "PUSH"
}, {
"hash" : "4f62e23c4ec3c38a510b4d3eb93935c6972b7e7e",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10675",
"triggerID" : "741151716",
"triggerType" : "MANUAL"
}, {
"hash" : "4f62e23c4ec3c38a510b4d3eb93935c6972b7e7e",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10667",
"triggerID" : "741151716",
"triggerType" : "MANUAL"
}, {
"hash" : "ccbb7ca839b16f8d587fbcc88cb42be1fee636fc",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10836",
"triggerID" : "ccbb7ca839b16f8d587fbcc88cb42be1fee636fc",
"triggerType" : "PUSH"
}, {
"hash" : "1618c8c9d6639b774ea6336b90a0c0b2ce888b80",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "1618c8c9d6639b774ea6336b90a0c0b2ce888b80",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 4f62e23c4ec3c38a510b4d3eb93935c6972b7e7e Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10675) Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10667)
* ccbb7ca839b16f8d587fbcc88cb42be1fee636fc Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10836)
* 1618c8c9d6639b774ea6336b90a0c0b2ce888b80 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14340: [FLINK-20533][datadog] Add Histogram support
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14340:
URL: https://github.com/apache/flink/pull/14340#issuecomment-740746774
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "4f62e23c4ec3c38a510b4d3eb93935c6972b7e7e",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10667",
"triggerID" : "4f62e23c4ec3c38a510b4d3eb93935c6972b7e7e",
"triggerType" : "PUSH"
}, {
"hash" : "4f62e23c4ec3c38a510b4d3eb93935c6972b7e7e",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10675",
"triggerID" : "741151716",
"triggerType" : "MANUAL"
}, {
"hash" : "4f62e23c4ec3c38a510b4d3eb93935c6972b7e7e",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10667",
"triggerID" : "741151716",
"triggerType" : "MANUAL"
}, {
"hash" : "ccbb7ca839b16f8d587fbcc88cb42be1fee636fc",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "ccbb7ca839b16f8d587fbcc88cb42be1fee636fc",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 4f62e23c4ec3c38a510b4d3eb93935c6972b7e7e Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10675) Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10667)
* ccbb7ca839b16f8d587fbcc88cb42be1fee636fc UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] rmetzger commented on a change in pull request #14340: [FLINK-20533][datadog] Add Histogram support
Posted by GitBox <gi...@apache.org>.
rmetzger commented on a change in pull request #14340:
URL: https://github.com/apache/flink/pull/14340#discussion_r540898612
##########
File path: flink-metrics/flink-metrics-datadog/src/main/java/org/apache/flink/metrics/datadog/DHistogram.java
##########
@@ -0,0 +1,61 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.metrics.datadog;
+
+import org.apache.flink.metrics.Histogram;
+import org.apache.flink.metrics.HistogramStatistics;
+
+import java.util.List;
+
+/**
+ * Maps histograms to datadog gauges.
+ *
+ * <p>Note: We cannot map them to datadog histograms because the HTTP API does not support them.
+ */
+public class DHistogram {
+ private final Histogram histogram;
+ private final MetricMetaData metaData;
+
+ public DHistogram(Histogram histogram, String metricName, String host, List<String> tags, Clock clock) {
+ this.histogram = histogram;
+ this.metaData = new MetricMetaData(MetricType.gauge, metricName, host, tags, clock);
+ }
+
+ public void addTo(DSeries series) {
+ final HistogramStatistics statistics = histogram.getStatistics();
+
+ // this selection is based on https://docs.datadoghq.com/developers/metrics/types/?tab=histogram
+ // we only exclude 'sum' (which is optional), because we cannot compute it
+ // the semantics for count are also slightly different, because we don't reset it after a report
+ series.add(new StaticDMetric(statistics.getMean(), withMetricNameSuffix(metaData, "avg")));
+ series.add(new StaticDMetric(histogram.getCount(), withMetricNameSuffix(metaData, "count")));
+ series.add(new StaticDMetric(statistics.getQuantile(.5), withMetricNameSuffix(metaData, "median")));
+ series.add(new StaticDMetric(statistics.getQuantile(.95), withMetricNameSuffix(metaData, "95percentile")));
+ series.add(new StaticDMetric(statistics.getMin(), withMetricNameSuffix(metaData, "min")));
+ series.add(new StaticDMetric(statistics.getMax(), withMetricNameSuffix(metaData, "max")));
Review comment:
This runs in a separate thread, but seems quite expensive with the string concat and the MetricsMetaData allocation each time we send the metric.
Does it make sense to initialize the MetaData with the different name suffixes in the constructor?
##########
File path: flink-metrics/flink-metrics-datadog/src/main/java/org/apache/flink/metrics/datadog/DatadogHttpClient.java
##########
@@ -113,8 +113,8 @@ public void send(DSeries request) throws Exception {
client.newCall(r).enqueue(EmptyCallback.getEmptyCallback());
}
- public static String serialize(Object obj) throws JsonProcessingException {
- return MAPPER.writeValueAsString(obj);
+ public static String serialize(Object obj, ObjectMapper mapper) throws JsonProcessingException {
+ return mapper.writeValueAsString(obj);
Review comment:
I understand you changed this for the tests, but it's a bit ugly. Maybe add a comment?
##########
File path: flink-metrics/flink-metrics-datadog/src/main/java/org/apache/flink/metrics/datadog/DatadogHttpClient.java
##########
@@ -113,8 +113,8 @@ public void send(DSeries request) throws Exception {
client.newCall(r).enqueue(EmptyCallback.getEmptyCallback());
}
- public static String serialize(Object obj) throws JsonProcessingException {
- return MAPPER.writeValueAsString(obj);
+ public static String serialize(Object obj, ObjectMapper mapper) throws JsonProcessingException {
+ return mapper.writeValueAsString(obj);
Review comment:
Strictly speaking this mapper is only necessary for having deterministic test results. The proper solution would probably be parsing the JSON response and compare the results not as a string.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zentol merged pull request #14340: [FLINK-20533][datadog] Add Histogram support
Posted by GitBox <gi...@apache.org>.
zentol merged pull request #14340:
URL: https://github.com/apache/flink/pull/14340
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zentol commented on a change in pull request #14340: [FLINK-20533][datadog] Add Histogram support
Posted by GitBox <gi...@apache.org>.
zentol commented on a change in pull request #14340:
URL: https://github.com/apache/flink/pull/14340#discussion_r540934164
##########
File path: flink-metrics/flink-metrics-datadog/src/main/java/org/apache/flink/metrics/datadog/DatadogHttpClient.java
##########
@@ -113,8 +113,8 @@ public void send(DSeries request) throws Exception {
client.newCall(r).enqueue(EmptyCallback.getEmptyCallback());
}
- public static String serialize(Object obj) throws JsonProcessingException {
- return MAPPER.writeValueAsString(obj);
+ public static String serialize(Object obj, ObjectMapper mapper) throws JsonProcessingException {
+ return mapper.writeValueAsString(obj);
Review comment:
Yeah I wasn't too happy with it either; it is especially finicky since every setting the reporter uses for the mapper is ignored by the test :/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14340: [FLINK-20533][datadog] Add Histogram support
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14340:
URL: https://github.com/apache/flink/pull/14340#issuecomment-740746774
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "4f62e23c4ec3c38a510b4d3eb93935c6972b7e7e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10667",
"triggerID" : "4f62e23c4ec3c38a510b4d3eb93935c6972b7e7e",
"triggerType" : "PUSH"
}, {
"hash" : "4f62e23c4ec3c38a510b4d3eb93935c6972b7e7e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10675",
"triggerID" : "741151716",
"triggerType" : "MANUAL"
}, {
"hash" : "4f62e23c4ec3c38a510b4d3eb93935c6972b7e7e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10667",
"triggerID" : "741151716",
"triggerType" : "MANUAL"
}, {
"hash" : "ccbb7ca839b16f8d587fbcc88cb42be1fee636fc",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10836",
"triggerID" : "ccbb7ca839b16f8d587fbcc88cb42be1fee636fc",
"triggerType" : "PUSH"
}, {
"hash" : "1618c8c9d6639b774ea6336b90a0c0b2ce888b80",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10837",
"triggerID" : "1618c8c9d6639b774ea6336b90a0c0b2ce888b80",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* ccbb7ca839b16f8d587fbcc88cb42be1fee636fc Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10836)
* 1618c8c9d6639b774ea6336b90a0c0b2ce888b80 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10837)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14340: [FLINK-20533][datadog] Add Histogram support
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14340:
URL: https://github.com/apache/flink/pull/14340#issuecomment-740746774
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "4f62e23c4ec3c38a510b4d3eb93935c6972b7e7e",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10667",
"triggerID" : "4f62e23c4ec3c38a510b4d3eb93935c6972b7e7e",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 4f62e23c4ec3c38a510b4d3eb93935c6972b7e7e Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10667)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14340: [FLINK-20533][datadog] Add Histogram support
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14340:
URL: https://github.com/apache/flink/pull/14340#issuecomment-740746774
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "4f62e23c4ec3c38a510b4d3eb93935c6972b7e7e",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10667",
"triggerID" : "4f62e23c4ec3c38a510b4d3eb93935c6972b7e7e",
"triggerType" : "PUSH"
}, {
"hash" : "4f62e23c4ec3c38a510b4d3eb93935c6972b7e7e",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10675",
"triggerID" : "741151716",
"triggerType" : "MANUAL"
}, {
"hash" : "4f62e23c4ec3c38a510b4d3eb93935c6972b7e7e",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10667",
"triggerID" : "741151716",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* 4f62e23c4ec3c38a510b4d3eb93935c6972b7e7e Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10675) Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10667)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14340: [FLINK-20533][datadog] Add Histogram support
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14340:
URL: https://github.com/apache/flink/pull/14340#issuecomment-740746774
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "4f62e23c4ec3c38a510b4d3eb93935c6972b7e7e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10667",
"triggerID" : "4f62e23c4ec3c38a510b4d3eb93935c6972b7e7e",
"triggerType" : "PUSH"
}, {
"hash" : "4f62e23c4ec3c38a510b4d3eb93935c6972b7e7e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10675",
"triggerID" : "741151716",
"triggerType" : "MANUAL"
}, {
"hash" : "4f62e23c4ec3c38a510b4d3eb93935c6972b7e7e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10667",
"triggerID" : "741151716",
"triggerType" : "MANUAL"
}, {
"hash" : "ccbb7ca839b16f8d587fbcc88cb42be1fee636fc",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10836",
"triggerID" : "ccbb7ca839b16f8d587fbcc88cb42be1fee636fc",
"triggerType" : "PUSH"
}, {
"hash" : "1618c8c9d6639b774ea6336b90a0c0b2ce888b80",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10837",
"triggerID" : "1618c8c9d6639b774ea6336b90a0c0b2ce888b80",
"triggerType" : "PUSH"
}, {
"hash" : "3dfcdba2dc6932632be7ef4391a03c7db3688b63",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "3dfcdba2dc6932632be7ef4391a03c7db3688b63",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 1618c8c9d6639b774ea6336b90a0c0b2ce888b80 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10837)
* 3dfcdba2dc6932632be7ef4391a03c7db3688b63 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zentol commented on a change in pull request #14340: [FLINK-20533][datadog] Add Histogram support
Posted by GitBox <gi...@apache.org>.
zentol commented on a change in pull request #14340:
URL: https://github.com/apache/flink/pull/14340#discussion_r540933465
##########
File path: flink-metrics/flink-metrics-datadog/src/main/java/org/apache/flink/metrics/datadog/DHistogram.java
##########
@@ -0,0 +1,61 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.metrics.datadog;
+
+import org.apache.flink.metrics.Histogram;
+import org.apache.flink.metrics.HistogramStatistics;
+
+import java.util.List;
+
+/**
+ * Maps histograms to datadog gauges.
+ *
+ * <p>Note: We cannot map them to datadog histograms because the HTTP API does not support them.
+ */
+public class DHistogram {
+ private final Histogram histogram;
+ private final MetricMetaData metaData;
+
+ public DHistogram(Histogram histogram, String metricName, String host, List<String> tags, Clock clock) {
+ this.histogram = histogram;
+ this.metaData = new MetricMetaData(MetricType.gauge, metricName, host, tags, clock);
+ }
+
+ public void addTo(DSeries series) {
+ final HistogramStatistics statistics = histogram.getStatistics();
+
+ // this selection is based on https://docs.datadoghq.com/developers/metrics/types/?tab=histogram
+ // we only exclude 'sum' (which is optional), because we cannot compute it
+ // the semantics for count are also slightly different, because we don't reset it after a report
+ series.add(new StaticDMetric(statistics.getMean(), withMetricNameSuffix(metaData, "avg")));
+ series.add(new StaticDMetric(histogram.getCount(), withMetricNameSuffix(metaData, "count")));
+ series.add(new StaticDMetric(statistics.getQuantile(.5), withMetricNameSuffix(metaData, "median")));
+ series.add(new StaticDMetric(statistics.getQuantile(.95), withMetricNameSuffix(metaData, "95percentile")));
+ series.add(new StaticDMetric(statistics.getMin(), withMetricNameSuffix(metaData, "min")));
+ series.add(new StaticDMetric(statistics.getMax(), withMetricNameSuffix(metaData, "max")));
Review comment:
Yes, we should do this only once in the constructor; it's a waste of resources to do this every time.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #14340: [FLINK-20533][datadog] Add Histogram support
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #14340:
URL: https://github.com/apache/flink/pull/14340#issuecomment-740746774
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "4f62e23c4ec3c38a510b4d3eb93935c6972b7e7e",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "4f62e23c4ec3c38a510b4d3eb93935c6972b7e7e",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 4f62e23c4ec3c38a510b4d3eb93935c6972b7e7e UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14340: [FLINK-20533][datadog] Add Histogram support
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14340:
URL: https://github.com/apache/flink/pull/14340#issuecomment-740746774
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "4f62e23c4ec3c38a510b4d3eb93935c6972b7e7e",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10667",
"triggerID" : "4f62e23c4ec3c38a510b4d3eb93935c6972b7e7e",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 4f62e23c4ec3c38a510b4d3eb93935c6972b7e7e Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10667)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14340: [FLINK-20533][datadog] Add Histogram support
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14340:
URL: https://github.com/apache/flink/pull/14340#issuecomment-740746774
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "4f62e23c4ec3c38a510b4d3eb93935c6972b7e7e",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10667",
"triggerID" : "4f62e23c4ec3c38a510b4d3eb93935c6972b7e7e",
"triggerType" : "PUSH"
}, {
"hash" : "4f62e23c4ec3c38a510b4d3eb93935c6972b7e7e",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10675",
"triggerID" : "741151716",
"triggerType" : "MANUAL"
}, {
"hash" : "4f62e23c4ec3c38a510b4d3eb93935c6972b7e7e",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10667",
"triggerID" : "741151716",
"triggerType" : "MANUAL"
}, {
"hash" : "ccbb7ca839b16f8d587fbcc88cb42be1fee636fc",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10836",
"triggerID" : "ccbb7ca839b16f8d587fbcc88cb42be1fee636fc",
"triggerType" : "PUSH"
}, {
"hash" : "1618c8c9d6639b774ea6336b90a0c0b2ce888b80",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10837",
"triggerID" : "1618c8c9d6639b774ea6336b90a0c0b2ce888b80",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 4f62e23c4ec3c38a510b4d3eb93935c6972b7e7e Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10675) Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10667)
* ccbb7ca839b16f8d587fbcc88cb42be1fee636fc Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10836)
* 1618c8c9d6639b774ea6336b90a0c0b2ce888b80 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10837)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14340: [FLINK-20533][datadog] Add Histogram support
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14340:
URL: https://github.com/apache/flink/pull/14340#issuecomment-740746774
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "4f62e23c4ec3c38a510b4d3eb93935c6972b7e7e",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10667",
"triggerID" : "4f62e23c4ec3c38a510b4d3eb93935c6972b7e7e",
"triggerType" : "PUSH"
}, {
"hash" : "4f62e23c4ec3c38a510b4d3eb93935c6972b7e7e",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10675",
"triggerID" : "741151716",
"triggerType" : "MANUAL"
}, {
"hash" : "4f62e23c4ec3c38a510b4d3eb93935c6972b7e7e",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10667",
"triggerID" : "741151716",
"triggerType" : "MANUAL"
}, {
"hash" : "ccbb7ca839b16f8d587fbcc88cb42be1fee636fc",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10836",
"triggerID" : "ccbb7ca839b16f8d587fbcc88cb42be1fee636fc",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 4f62e23c4ec3c38a510b4d3eb93935c6972b7e7e Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10675) Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10667)
* ccbb7ca839b16f8d587fbcc88cb42be1fee636fc Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10836)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14340: [FLINK-20533][datadog] Add Histogram support
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14340:
URL: https://github.com/apache/flink/pull/14340#issuecomment-740746774
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "4f62e23c4ec3c38a510b4d3eb93935c6972b7e7e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10667",
"triggerID" : "4f62e23c4ec3c38a510b4d3eb93935c6972b7e7e",
"triggerType" : "PUSH"
}, {
"hash" : "4f62e23c4ec3c38a510b4d3eb93935c6972b7e7e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10675",
"triggerID" : "741151716",
"triggerType" : "MANUAL"
}, {
"hash" : "4f62e23c4ec3c38a510b4d3eb93935c6972b7e7e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10667",
"triggerID" : "741151716",
"triggerType" : "MANUAL"
}, {
"hash" : "ccbb7ca839b16f8d587fbcc88cb42be1fee636fc",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10836",
"triggerID" : "ccbb7ca839b16f8d587fbcc88cb42be1fee636fc",
"triggerType" : "PUSH"
}, {
"hash" : "1618c8c9d6639b774ea6336b90a0c0b2ce888b80",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10837",
"triggerID" : "1618c8c9d6639b774ea6336b90a0c0b2ce888b80",
"triggerType" : "PUSH"
}, {
"hash" : "3dfcdba2dc6932632be7ef4391a03c7db3688b63",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10893",
"triggerID" : "3dfcdba2dc6932632be7ef4391a03c7db3688b63",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 3dfcdba2dc6932632be7ef4391a03c7db3688b63 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10893)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org