[GitHub] [dolphinscheduler] lenboo commented on pull request #8408: [Fix-8296][API] Update process definition error

[GitBox <gi...@apache.org>]

lenboo commented on pull request #8408:
URL: https://github.com/apache/dolphinscheduler/pull/8408#issuecomment-1049487583


   > **I think we could do this, but it better do not do it again.**
   > 
   > I check table `t_ds_task_definition_log`, it seems we have sql syntax `having count > 1` to make sure we only delete multiple records. So DML in `t_ds_task_definition_log` look good to me.
   > 
   > But I am not sure the unique key of table `t_ds_process_task_relation_log`, although it has `having count > 1` to make sure the record is multiple. please double check table `t_ds_process_task_relation_log` unique key here @caishunfeng @JinyLeeChina @lenboo
   > 
   > If we make sure is unique key of two tables. I think it makes sense to me.
   > 
   > **But** as @caishunfeng said, it is a dangerous behavior due to we use `delete` syntax in DML because it will auto-run when user installs the software. Maybe we should add an optioned script about this next time. Or even use documents to alert users
   
   - I think we could do this 
   agree +1 
   
   -  but it better do not do it again.
   Because we will change our data structure according to unknown requirements in the future, we cannot determine what the future data structure will look like, including adding, modifying and deleting some fields. 
   
   - But as @caishunfeng said, it is a dangerous behavior due to we use delete syntax in DML because it will auto-run when user installs the software. Maybe we should add an optioned script about this next time. Or even use documents to alert users 
   Yes, it's dangerous, but we have no choice. We should declare this in the documents, so that users can back up the meta data in advance.
   
   
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org