You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Yifan Cai (Jira)" <ji...@apache.org> on 2020/01/28 19:19:00 UTC
[jira] [Comment Edited] (CASSANDRA-15308) Fix flakey
testAcquireReleaseOutbound - org.apache.cassandra.net.ConnectionTest
[ https://issues.apache.org/jira/browse/CASSANDRA-15308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17025382#comment-17025382 ]
Yifan Cai edited comment on CASSANDRA-15308 at 1/28/20 7:18 PM:
----------------------------------------------------------------
[Code|https://github.com/yifan-c/cassandra/tree/CASSANDRA-15308], [PR|https://github.com/apache/cassandra/pull/433], [Test|https://app.circleci.com/github/yifan-c/cassandra/pipelines/55450fa4-3a68-4136-aa35-927daf158687/workflows/94e4335b-a73f-43c2-9a5a-4e5e6ad43c49]
{{testAcquireReleaseOutbound}} starts multiple testing rounds. In each round, it set up the test settings and starts N threads to contend for capacity.
The test fails due to leaking resources (insufficient global capacity).
The global limit that tracks the global capacity usage is shred among different rounds, and the reserved capacity is not completely released in each round.
The patch fixes the test by releasing all pending capacity at the end of each round.
was (Author: yifanc):
[Code|https://github.com/yifan-c/cassandra/tree/CASSANDRA-15308], [PR|https://github.com/apache/cassandra/pull/433], [Test|https://app.circleci.com/github/yifan-c/cassandra/pipelines/55450fa4-3a68-4136-aa35-927daf158687/workflows/94e4335b-a73f-43c2-9a5a-4e5e6ad43c49]
{{testAcquireReleaseOutbound}} starts multiple testing rounds. In each round, it setups the test settings and starts N threads to contend for capacity.
The test fails due to leaking resources (insufficient global capacity).
The global limit that tracks the global capacity usage is shred among different rounds, and the reserved capacity is not completely released in each round.
The patch fixes the test by releasing all pending capacity at the end of each round.
> Fix flakey testAcquireReleaseOutbound - org.apache.cassandra.net.ConnectionTest
> -------------------------------------------------------------------------------
>
> Key: CASSANDRA-15308
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15308
> Project: Cassandra
> Issue Type: Bug
> Components: Test/unit
> Reporter: Joey Lynch
> Assignee: Yifan Cai
> Priority: Normal
> Fix For: 4.0-alpha
>
>
> Example failure: https://circleci.com/gh/jolynch/cassandra/554#tests/containers/61
> {noformat}
> Your job ran 4428 tests with 1 failure
> - testAcquireReleaseOutbound - org.apache.cassandra.net.ConnectionTest
> junit.framework.AssertionFailedError
> at org.apache.cassandra.net.ConnectionTest.lambda$testAcquireReleaseOutbound$53(ConnectionTest.java:770)
> at org.apache.cassandra.net.ConnectionTest.lambda$doTest$8(ConnectionTest.java:238)
> at org.apache.cassandra.net.ConnectionTest.doTestManual(ConnectionTest.java:258)
> at org.apache.cassandra.net.ConnectionTest.doTest(ConnectionTest.java:236)
> at org.apache.cassandra.net.ConnectionTest.test(ConnectionTest.java:225)
> at org.apache.cassandra.net.ConnectionTest.testAcquireReleaseOutbound(ConnectionTest.java:767) {noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org