You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by kf...@apache.org on 2013/02/08 09:24:36 UTC
svn commit: r1443872 -
/tomcat/trunk/java/org/apache/catalina/storeconfig/StoreConfigLifecycleListener.java
Author: kfujino
Date: Fri Feb 8 08:24:36 2013
New Revision: 1443872
URL: http://svn.apache.org/r1443872
Log:
Don't use a hard-coded domain name.
Modified:
tomcat/trunk/java/org/apache/catalina/storeconfig/StoreConfigLifecycleListener.java
Modified: tomcat/trunk/java/org/apache/catalina/storeconfig/StoreConfigLifecycleListener.java
URL: http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/storeconfig/StoreConfigLifecycleListener.java?rev=1443872&r1=1443871&r2=1443872&view=diff
==============================================================================
--- tomcat/trunk/java/org/apache/catalina/storeconfig/StoreConfigLifecycleListener.java (original)
+++ tomcat/trunk/java/org/apache/catalina/storeconfig/StoreConfigLifecycleListener.java Fri Feb 8 08:24:36 2013
@@ -90,7 +90,7 @@ public class StoreConfigLifecycleListene
MBeanServer mserver = MBeanUtils.createServer();
InputStream descriptor = null;
try {
- ObjectName objectName = new ObjectName("Catalina:type=StoreConfig" );
+ ObjectName objectName = new ObjectName(server.getDomain() + ":type=StoreConfig" );
if (!mserver.isRegistered(objectName)) {
registry.registerComponent(storeConfig, objectName, "StoreConfig");
}
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: svn commit: r1443872 - /tomcat/trunk/java/org/apache/catalina/storeconfig/StoreConfigLifecycleListener.java
Posted by Konstantin Kolinko <kn...@gmail.com>.
2013/2/8 Remy Maucherat <re...@apache.org>:
> On Fri, 2013-02-08 at 08:24 +0000, kfujino@apache.org wrote:
>> Author: kfujino
>> Date: Fri Feb 8 08:24:36 2013
>> New Revision: 1443872
>>
>> URL: http://svn.apache.org/r1443872
>> Log:
>> Don't use a hard-coded domain name.
>
> Actually, I'm not sure this is a good plan. This was most certainly
> hardcoded on purpose, so that the mbean is always available at a known
> location, and from where it could handle the full container (with
> multiple servers/domains ?). Don't know exactly what Peter had in mind
> though.
>
If it is indeed hard-coded then I think it would be better to use a
distinct name, such as "TomcatStoreConfig" or "CatalinaStoreConfig".
Best regards,
Konstantin Kolinko
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: svn commit: r1443872 - /tomcat/trunk/java/org/apache/catalina/storeconfig/StoreConfigLifecycleListener.java
Posted by Keiichi Fujino <kf...@apache.org>.
2013/2/8 Remy Maucherat <re...@apache.org>:
> On Fri, 2013-02-08 at 08:24 +0000, kfujino@apache.org wrote:
>> Author: kfujino
>> Date: Fri Feb 8 08:24:36 2013
>> New Revision: 1443872
>>
>> URL: http://svn.apache.org/r1443872
>> Log:
>> Don't use a hard-coded domain name.
>
> Actually, I'm not sure this is a good plan. This was most certainly
> hardcoded on purpose, so that the mbean is always available at a known
> location, and from where it could handle the full container (with
> multiple servers/domains ?). Don't know exactly what Peter had in mind
> though.
>
OK.
I will revert it.
--
Keiichi.Fujino
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: svn commit: r1443872 -
/tomcat/trunk/java/org/apache/catalina/storeconfig/StoreConfigLifecycleListener.java
Posted by Remy Maucherat <re...@apache.org>.
On Fri, 2013-02-08 at 08:24 +0000, kfujino@apache.org wrote:
> Author: kfujino
> Date: Fri Feb 8 08:24:36 2013
> New Revision: 1443872
>
> URL: http://svn.apache.org/r1443872
> Log:
> Don't use a hard-coded domain name.
Actually, I'm not sure this is a good plan. This was most certainly
hardcoded on purpose, so that the mbean is always available at a known
location, and from where it could handle the full container (with
multiple servers/domains ?). Don't know exactly what Peter had in mind
though.
Rémy
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org