[GitHub] [hudi] alexeykudinkin commented on a diff in pull request #7379: [HUDI-5323] Support virtual keys in Bloom Index and always write bloom filters to parquet files

["alexeykudinkin (via GitHub)" <gi...@apache.org>]

alexeykudinkin commented on code in PR #7379:
URL: https://github.com/apache/hudi/pull/7379#discussion_r1086091096


##########
hudi-client/hudi-spark-client/src/main/java/org/apache/hudi/io/storage/HoodieSparkParquetReader.java:
##########
@@ -79,8 +82,8 @@ public BloomFilter readBloomFilter() {
   }
 
   @Override
-  public Set<String> filterRowKeys(Set<String> candidateRowKeys) {
-    return parquetUtils.filterRowKeys(conf, path, candidateRowKeys);
+  public Set<String> filterRowKeys(Option<BaseKeyGenerator> keyGeneratorOpt, Option<SerializableSchema> schemaOpt, Set<String> candidateRowKeys) {

Review Comment:
   Chatted offline: we should avoid exposing FileReader and ParquetUtils to the KeyGenerators, instead we need to think about providing an abstraction providing:
   
    - Proper projected schema necessary for it to be able to produce the record key
    - Produce actual key (from the projected version of the object)
   
   This abstraction have to be
    - As performant as using meta-fields for Simple KG



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org