You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/01/30 05:16:35 UTC

[GitHub] [arrow] jorgecarleitao commented on pull request #9366: ARROW-11434: [Rust][DataFusion] Rename length kernel to octet_length

jorgecarleitao commented on pull request #9366:
URL: https://github.com/apache/arrow/pull/9366#issuecomment-770159697


   I agree that it may be misleading, but from Rust's perspective, it is not "incorrect" to use `length` to denote the number of bytes of a string: `String::len` uses the same convention, and you need to use `s.chars().count()` to call the number of characters.
   
   This also collides with #9353, where `length` is extended to support `ListArray` and `BinaryArray`.
   
   One idea is to keep the name as is on the arrow crate, but name it `octet_length` on DataFusion's SQL and API (to be consistent with Postgres).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org