You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/12/30 02:12:27 UTC

[GitHub] [spark] gengliangwang opened a new pull request #27045: [SPARK-27506][SQL][FollowUp] Use option `avroSchema` for expect schema and remove option `actualSchema`

gengliangwang opened a new pull request #27045: [SPARK-27506][SQL][FollowUp] Use option `avroSchema` for expect schema and remove option `actualSchema`
URL: https://github.com/apache/spark/pull/27045
 
 
   <!--
   Thanks for sending a pull request!  Here are some tips for you:
     1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
     2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
     3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
     4. Be sure to keep the PR description updated to reflect all changes.
     5. Please write your PR title to summarize what this PR proposes.
     6. If possible, provide a concise example to reproduce the issue for a faster review.
   -->
   
   ### What changes were proposed in this pull request?
   <!--
   Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue. 
   If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
     1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
     2. If you fix some SQL features, you can provide some references of other DBMSes.
     3. If there is design documentation, please add the link.
     4. If there is a discussion in the mailing list, please add the link.
   -->
   This is a follow-up of https://github.com/apache/spark/pull/26780
   In https://github.com/apache/spark/pull/26780, a new Avro data source option `actualSchema` is introduced for setting the original Avro schema in function `from_avro`, while the expected schema is supposed to be set in the parameter `jsonFormatSchema` of `from_avro`. 
   
   However, there is another Avro data source option `avroSchema`. It is used for setting the expected schema in readiong and writing.
   
   This PR is to use the option `avroSchema` option for  reading Avro data with an evolved schema and remove the new one `actualSchema`
   
   ### Why are the changes needed?
   <!--
   Please clarify why the changes are needed. For instance,
     1. If you propose a new API, clarify the use case for a new API.
     2. If you fix a bug, you can clarify why it is a bug.
   -->
   Unify and simplify the Avro data source options.
   
   
   ### Does this PR introduce any user-facing change?
   <!--
   If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
   If no, write 'No'.
   -->
   Yes.
   To deserialize Avro data with an evolved schema, before changes:
   ```
   from_avro('col, expectedSchema, ("actualSchema" -> actualSchema))
   ```
   
   After changes:
   ```
   from_avro('col, actualSchema, ("avroSchema" -> expectedSchema))
   ```
   
   ### How was this patch tested?
   <!--
   If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
   If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
   If tests were not added, please describe why they were not added and/or why it was difficult to add.
   -->
   Update the existing tests in https://github.com/apache/spark/pull/26780

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA removed a comment on issue #27045: [SPARK-27506][SQL][FOLLOWUP] Use option `avroSchema` to specify an evolved schema in `from_avro`

Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #27045: [SPARK-27506][SQL][FOLLOWUP] Use option `avroSchema` to specify an evolved schema in `from_avro`
URL: https://github.com/apache/spark/pull/27045#issuecomment-569613238
 
 
   **[Test build #115944 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/115944/testReport)** for PR 27045 at commit [`9fdc9bb`](https://github.com/apache/spark/commit/9fdc9bbdf5c1053c4268dc176b9df84f11f180e5).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] HyukjinKwon commented on a change in pull request #27045: [SPARK-27506][SQL][FOLLOWUP] Use option `avroSchema` to specify an evolved schema in `from_avro`

Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on a change in pull request #27045: [SPARK-27506][SQL][FOLLOWUP] Use option `avroSchema` to specify an evolved schema in `from_avro`
URL: https://github.com/apache/spark/pull/27045#discussion_r361908355
 
 

 ##########
 File path: external/avro/src/main/scala/org/apache/spark/sql/avro/AvroOptions.scala
 ##########
 @@ -36,18 +36,14 @@ class AvroOptions(
   }
 
   /**
-   * Optional schema provided by an user in JSON format.
+   * Optional schema provided by an user in JSON format. This option can be set when
+   * 1. for reading Avro, the expected schema for deserialization is compatible with
 
 Review comment:
   This wording sounds a bit unclear to me.
   
   > When reading, the provided Avro schema should be compatible with the Avro schema from the actual data.
   > When writing, the provided Avro schema should be compatible with the Avro schema converted from Spark schema.
   
   Is it correct?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on issue #27045: [SPARK-27506][SQL][FollowUp] Use option `avroSchema` to specify an evolved schema in `from_avro`

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27045: [SPARK-27506][SQL][FollowUp] Use option `avroSchema` to specify an evolved schema in `from_avro`
URL: https://github.com/apache/spark/pull/27045#issuecomment-569567636
 
 
   Test PASSed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/115926/
   Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on issue #27045: [SPARK-27506][SQL][FOLLOWUP] Use option `avroSchema` to specify an evolved schema in `from_avro`

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27045: [SPARK-27506][SQL][FOLLOWUP] Use option `avroSchema` to specify an evolved schema in `from_avro`
URL: https://github.com/apache/spark/pull/27045#issuecomment-569612177
 
 
   Merged build finished. Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] HyukjinKwon commented on a change in pull request #27045: [SPARK-27506][SQL][FOLLOWUP] Use option `avroSchema` to specify an evolved schema in `from_avro`

Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on a change in pull request #27045: [SPARK-27506][SQL][FOLLOWUP] Use option `avroSchema` to specify an evolved schema in `from_avro`
URL: https://github.com/apache/spark/pull/27045#discussion_r361908373
 
 

 ##########
 File path: external/avro/src/main/scala/org/apache/spark/sql/avro/AvroOptions.scala
 ##########
 @@ -36,18 +36,14 @@ class AvroOptions(
   }
 
   /**
-   * Optional schema provided by an user in JSON format.
+   * Optional schema provided by an user in JSON format. This option can be set when
 
 Review comment:
   nit: `an user` -> `a user`
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on issue #27045: [SPARK-27506][SQL][FOLLOWUP] Use option `avroSchema` to specify an evolved schema in `from_avro`

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27045: [SPARK-27506][SQL][FOLLOWUP] Use option `avroSchema` to specify an evolved schema in `from_avro`
URL: https://github.com/apache/spark/pull/27045#issuecomment-569612186
 
 
   Test PASSed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/20734/
   Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on issue #27045: [SPARK-27506][SQL][FOLLOWUP] Use option `avroSchema` to specify an evolved schema in `from_avro`

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27045: [SPARK-27506][SQL][FOLLOWUP] Use option `avroSchema` to specify an evolved schema in `from_avro`
URL: https://github.com/apache/spark/pull/27045#issuecomment-569618278
 
 
   Merged build finished. Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on issue #27045: [SPARK-27506][SQL][FOLLOWUP] Use option `avroSchema` to specify an evolved schema in `from_avro`

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27045: [SPARK-27506][SQL][FOLLOWUP] Use option `avroSchema` to specify an evolved schema in `from_avro`
URL: https://github.com/apache/spark/pull/27045#issuecomment-569618278
 
 
   Merged build finished. Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on issue #27045: [SPARK-27506][SQL][FOLLOWUP] Use option `avroSchema` to specify an evolved schema in `from_avro`

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27045: [SPARK-27506][SQL][FOLLOWUP] Use option `avroSchema` to specify an evolved schema in `from_avro`
URL: https://github.com/apache/spark/pull/27045#issuecomment-569612186
 
 
   Test PASSed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/20734/
   Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on issue #27045: [SPARK-27506][SQL][FOLLOWUP] Use option `avroSchema` to specify an evolved schema in `from_avro`

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27045: [SPARK-27506][SQL][FOLLOWUP] Use option `avroSchema` to specify an evolved schema in `from_avro`
URL: https://github.com/apache/spark/pull/27045#issuecomment-569618284
 
 
   Test PASSed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/115944/
   Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on issue #27045: [SPARK-27506][SQL][FollowUp] Use option `avroSchema` to specify an evolved schema in `from_avro`

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27045: [SPARK-27506][SQL][FollowUp] Use option `avroSchema` to specify an evolved schema in `from_avro`
URL: https://github.com/apache/spark/pull/27045#issuecomment-569564740
 
 
   Merged build finished. Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] HyukjinKwon closed pull request #27045: [SPARK-27506][SQL][FOLLOWUP] Use option `avroSchema` to specify an evolved schema in `from_avro`

Posted by GitBox <gi...@apache.org>.
HyukjinKwon closed pull request #27045: [SPARK-27506][SQL][FOLLOWUP] Use option `avroSchema` to specify an evolved schema in `from_avro`
URL: https://github.com/apache/spark/pull/27045
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on issue #27045: [SPARK-27506][SQL][FOLLOWUP] Use option `avroSchema` to specify an evolved schema in `from_avro`

Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27045: [SPARK-27506][SQL][FOLLOWUP] Use option `avroSchema` to specify an evolved schema in `from_avro`
URL: https://github.com/apache/spark/pull/27045#issuecomment-569618071
 
 
   **[Test build #115944 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/115944/testReport)** for PR 27045 at commit [`9fdc9bb`](https://github.com/apache/spark/commit/9fdc9bbdf5c1053c4268dc176b9df84f11f180e5).
    * This patch passes all tests.
    * This patch merges cleanly.
    * This patch adds no public classes.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on issue #27045: [SPARK-27506][SQL][FollowUp] Use option `avroSchema` to specify an evolved schema in `from_avro`

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27045: [SPARK-27506][SQL][FollowUp] Use option `avroSchema` to specify an evolved schema in `from_avro`
URL: https://github.com/apache/spark/pull/27045#issuecomment-569567635
 
 
   Merged build finished. Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] gengliangwang commented on issue #27045: [SPARK-27506][SQL][FollowUp] Use option `avroSchema` for expect schema and remove option `actualSchema`

Posted by GitBox <gi...@apache.org>.
gengliangwang commented on issue #27045: [SPARK-27506][SQL][FollowUp] Use option `avroSchema` for expect schema and remove option `actualSchema`
URL: https://github.com/apache/spark/pull/27045#issuecomment-569564114
 
 
   @giamo @Fokko @cloud-fan @HyukjinKwon 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on issue #27045: [SPARK-27506][SQL][FollowUp] Use option `avroSchema` to specify an evolved schema in `from_avro`

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27045: [SPARK-27506][SQL][FollowUp] Use option `avroSchema` to specify an evolved schema in `from_avro`
URL: https://github.com/apache/spark/pull/27045#issuecomment-569564743
 
 
   Test PASSed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/20717/
   Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on issue #27045: [SPARK-27506][SQL][FollowUp] Use option `avroSchema` to specify an evolved schema in `from_avro`

Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27045: [SPARK-27506][SQL][FollowUp] Use option `avroSchema` to specify an evolved schema in `from_avro`
URL: https://github.com/apache/spark/pull/27045#issuecomment-569564605
 
 
   **[Test build #115926 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/115926/testReport)** for PR 27045 at commit [`6803519`](https://github.com/apache/spark/commit/68035192d773e6b68019a4e2319a03011dae9929).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] gengliangwang commented on a change in pull request #27045: [SPARK-27506][SQL][FOLLOWUP] Use option `avroSchema` to specify an evolved schema in `from_avro`

Posted by GitBox <gi...@apache.org>.
gengliangwang commented on a change in pull request #27045: [SPARK-27506][SQL][FOLLOWUP] Use option `avroSchema` to specify an evolved schema in `from_avro`
URL: https://github.com/apache/spark/pull/27045#discussion_r361922716
 
 

 ##########
 File path: external/avro/src/main/scala/org/apache/spark/sql/avro/AvroOptions.scala
 ##########
 @@ -36,18 +36,14 @@ class AvroOptions(
   }
 
   /**
-   * Optional schema provided by an user in JSON format.
+   * Optional schema provided by an user in JSON format. This option can be set when
+   * 1. for reading Avro, the expected schema for deserialization is compatible with
 
 Review comment:
   Yes. I was trying to explain the actual usage.
   The doc is revised in my latest commit.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on issue #27045: [SPARK-27506][SQL][FOLLOWUP] Use option `avroSchema` to specify an evolved schema in `from_avro`

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27045: [SPARK-27506][SQL][FOLLOWUP] Use option `avroSchema` to specify an evolved schema in `from_avro`
URL: https://github.com/apache/spark/pull/27045#issuecomment-569618284
 
 
   Test PASSed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/115944/
   Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA removed a comment on issue #27045: [SPARK-27506][SQL][FollowUp] Use option `avroSchema` to specify an evolved schema in `from_avro`

Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #27045: [SPARK-27506][SQL][FollowUp] Use option `avroSchema` to specify an evolved schema in `from_avro`
URL: https://github.com/apache/spark/pull/27045#issuecomment-569564605
 
 
   **[Test build #115926 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/115926/testReport)** for PR 27045 at commit [`6803519`](https://github.com/apache/spark/commit/68035192d773e6b68019a4e2319a03011dae9929).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on issue #27045: [SPARK-27506][SQL][FollowUp] Use option `avroSchema` to specify an evolved schema in `from_avro`

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27045: [SPARK-27506][SQL][FollowUp] Use option `avroSchema` to specify an evolved schema in `from_avro`
URL: https://github.com/apache/spark/pull/27045#issuecomment-569567635
 
 
   Merged build finished. Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] cloud-fan commented on issue #27045: [SPARK-27506][SQL][FOLLOWUP] Use option `avroSchema` to specify an evolved schema in `from_avro`

Posted by GitBox <gi...@apache.org>.
cloud-fan commented on issue #27045: [SPARK-27506][SQL][FOLLOWUP] Use option `avroSchema` to specify an evolved schema in `from_avro`
URL: https://github.com/apache/spark/pull/27045#issuecomment-569590321
 
 
   +1 to have less options

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on issue #27045: [SPARK-27506][SQL][FollowUp] Use option `avroSchema` to specify an evolved schema in `from_avro`

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27045: [SPARK-27506][SQL][FollowUp] Use option `avroSchema` to specify an evolved schema in `from_avro`
URL: https://github.com/apache/spark/pull/27045#issuecomment-569567636
 
 
   Test PASSed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/115926/
   Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on issue #27045: [SPARK-27506][SQL][FOLLOWUP] Use option `avroSchema` to specify an evolved schema in `from_avro`

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27045: [SPARK-27506][SQL][FOLLOWUP] Use option `avroSchema` to specify an evolved schema in `from_avro`
URL: https://github.com/apache/spark/pull/27045#issuecomment-569612177
 
 
   Merged build finished. Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on issue #27045: [SPARK-27506][SQL][FollowUp] Use option `avroSchema` to specify an evolved schema in `from_avro`

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27045: [SPARK-27506][SQL][FollowUp] Use option `avroSchema` to specify an evolved schema in `from_avro`
URL: https://github.com/apache/spark/pull/27045#issuecomment-569564743
 
 
   Test PASSed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/20717/
   Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on issue #27045: [SPARK-27506][SQL][FollowUp] Use option `avroSchema` to specify an evolved schema in `from_avro`

Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27045: [SPARK-27506][SQL][FollowUp] Use option `avroSchema` to specify an evolved schema in `from_avro`
URL: https://github.com/apache/spark/pull/27045#issuecomment-569567542
 
 
   **[Test build #115926 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/115926/testReport)** for PR 27045 at commit [`6803519`](https://github.com/apache/spark/commit/68035192d773e6b68019a4e2319a03011dae9929).
    * This patch passes all tests.
    * This patch merges cleanly.
    * This patch adds no public classes.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on issue #27045: [SPARK-27506][SQL][FollowUp] Use option `avroSchema` to specify an evolved schema in `from_avro`

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27045: [SPARK-27506][SQL][FollowUp] Use option `avroSchema` to specify an evolved schema in `from_avro`
URL: https://github.com/apache/spark/pull/27045#issuecomment-569564740
 
 
   Merged build finished. Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] HyukjinKwon commented on issue #27045: [SPARK-27506][SQL][FOLLOWUP] Use option `avroSchema` to specify an evolved schema in `from_avro`

Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on issue #27045: [SPARK-27506][SQL][FOLLOWUP] Use option `avroSchema` to specify an evolved schema in `from_avro`
URL: https://github.com/apache/spark/pull/27045#issuecomment-569621956
 
 
   Merged to master.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on issue #27045: [SPARK-27506][SQL][FOLLOWUP] Use option `avroSchema` to specify an evolved schema in `from_avro`

Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27045: [SPARK-27506][SQL][FOLLOWUP] Use option `avroSchema` to specify an evolved schema in `from_avro`
URL: https://github.com/apache/spark/pull/27045#issuecomment-569613238
 
 
   **[Test build #115944 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/115944/testReport)** for PR 27045 at commit [`9fdc9bb`](https://github.com/apache/spark/commit/9fdc9bbdf5c1053c4268dc176b9df84f11f180e5).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org