You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by "NJ-Tokki (via GitHub)" <gi...@apache.org> on 2023/08/13 08:34:41 UTC

[GitHub] [airflow] NJ-Tokki opened a new pull request, #33363: Allow templating flower ingress hostnames

NJ-Tokki opened a new pull request, #33363:
URL: https://github.com/apache/airflow/pull/33363

   I would like to propose allowing template values to flower ingress hostnames.
   
   Why is it needed?
   Let's assume that we're providing airflow service to multiple teams.
   By creating flower ingress hostnames using <code>{{ .Release.Namespace }}</code> or <code>{{ .Release.Name }}</code>,
   there is no need to create multiple values files to store different hostnames for each team.
   
   Usage
   ```yaml
       hosts:
       #   # The hostname for the flower Ingress (can be templated)
       - name: {{ .Release.Namespace }}.airflow.service.com
   ```
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] boring-cyborg[bot] commented on pull request #33363: Allow templating flower ingress hostnames

Posted by "boring-cyborg[bot] (via GitHub)" <gi...@apache.org>.

boring-cyborg[bot] commented on PR #33363:
URL: https://github.com/apache/airflow/pull/33363#issuecomment-1676499623

   Awesome work, congrats on your first merged pull request! You are invited to check our [Issue Tracker](https://github.com/apache/airflow/issues) for additional contributions.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] potiuk merged pull request #33363: Allow templating flower ingress hostnames

Posted by "potiuk (via GitHub)" <gi...@apache.org>.

potiuk merged PR #33363:
URL: https://github.com/apache/airflow/pull/33363


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org