You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2020/10/23 13:16:29 UTC
[GitHub] [cloudstack] kioie commented on a change in pull request #3997: New API endpoint: UpdateVlanIpRange
kioie commented on a change in pull request #3997:
URL: https://github.com/apache/cloudstack/pull/3997#discussion_r510875852
##########
File path: api/src/main/java/com/cloud/configuration/ConfigurationService.java
##########
@@ -272,6 +273,22 @@
Vlan createVlanAndPublicIpRange(CreateVlanIpRangeCmd cmd) throws InsufficientCapacityException, ConcurrentOperationException, ResourceUnavailableException,
ResourceAllocationException;
+ /**
+ * Updates the IP address Range for the VLAN on the database, a
+ *
+ * @param cmd
+ * @param vlanId
+ * @param gateway
+ * @param startIP
+ * @param endIP
+ * @param netmask
+ * @throws com.cloud.exception.ConcurrentOperationException
+ * @throws com.cloud.exception.ResourceUnavailableException
+ * @throws com.cloud.exception.ResourceAllocationException
Review comment:
added unit tests.
##########
File path: engine/components-api/src/main/java/com/cloud/configuration/ConfigurationManager.java
##########
@@ -220,6 +220,11 @@ Vlan createVlanAndPublicIpRange(long zoneId, long networkId, long physicalNetwor
String vlanGateway, String vlanNetmask, String vlanId, boolean bypassVlanOverlapCheck, Domain domain, Account vlanOwner, String startIPv6, String endIPv6, String vlanIp6Gateway, String vlanIp6Cidr)
throws InsufficientCapacityException, ConcurrentOperationException, InvalidParameterValueException;
+ /* (non-Javadoc)
+ * @see com.cloud.configuration.ConfigurationManager#updateVlanAndPublicIpRange(long,String,String,String,String)
Review comment:
resolved
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org