[GitHub] [hbase] bharathv commented on a change in pull request #1102: HBASE-23752: Fix remaining test failures from nightly runs

[GitBox <gi...@apache.org>]

bharathv commented on a change in pull request #1102: HBASE-23752: Fix remaining test failures from nightly runs
URL: https://github.com/apache/hbase/pull/1102#discussion_r372530454
 
 

 ##########
 File path: hbase-server/src/test/java/org/apache/hadoop/hbase/security/provider/TestCustomSaslAuthenticationProvider.java
 ##########
 @@ -431,9 +431,13 @@ public static void setupCluster() throws Exception {
         UTIL.getDataTestDir("keytab").toUri().getPath());
     final MiniKdc kdc = UTIL.setupMiniKdc(KEYTAB_FILE);
 
-    // Switch back to NIO for now.
+    // Switch to blocking RPC impl.
     CONF.set(RpcClientFactory.CUSTOM_RPC_CLIENT_IMPL_CONF_KEY, BlockingRpcClient.class.getName());
     CONF.set(RpcServerFactory.CUSTOM_RPC_SERVER_IMPL_CONF_KEY, SimpleRpcServer.class.getName());
+    // Set the connection registry to ZKConnectionRegistry since hedging is not supported on
+    // blocking rpc clients.
 
 Review comment:
   > Why is this test forced onto the blocking rpc client? Can/Should it be parameterized over both implementations?
   
   Not totally sure why it should only be a blocking rpc client (and a SimpleRpcServer impl). @joshelser Any idea? I see that you are the author of this test.
   
   > can we not use the MasterRegistry with hedged rpcs disabled? It appears this configuration is supported by the MasterRegistry constructor.
   
   We can. But my comment above has nothing to do with whether hedging is enabled/disabled. HedgingRpcChannel is a non-blocking channel implementation. Using a non-blocking-channel wrapped over a blocking-rpc-connection defeats the purpose. 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services