You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by "ralf0131 (GitHub)" <gi...@apache.org> on 2019/03/14 16:50:25 UTC

[GitHub] [incubator-dubbo] ralf0131 opened pull request #3663: [Dubbo-3653] etcd as config center

## What is the purpose of the change

This pull request adds the etcd support as config center. #3653 

## Brief changelog

* Support get dubbo.properties from etcd
* Support listen to updates to configurator, routers, and etc.

## Verifying this change

Verified using this [sample](https://github.com/apache/incubator-dubbo-samples/tree/master/dubbo-samples-governance/dubbo-samples-servicelevel-override).

Follow this checklist to help us incorporate your contribution quickly and easily:

- [x] Make sure there is a [GITHUB_issue](https://github.com/apache/incubator-dubbo/issues) field for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
- [x] Format the pull request title like `[Dubbo-XXX] Fix UnknownException when host config not exist #XXX`. Each commit in the pull request should have a meaningful subject line and body.
- [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [x] Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in [test module](https://github.com/apache/incubator-dubbo/tree/master/dubbo-test).
- [ ] Run `mvn clean install -DskipTests=false` & `mvn clean test-compile failsafe:integration-test` to make sure unit-test and integration-test pass.
- [ ] If this contribution is large, please follow the [Software Donation Guide](https://github.com/apache/incubator-dubbo/wiki/Software-donation-guide).


[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3663 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [incubator-dubbo] ralf0131 commented on issue #3663: [Dubbo-3653] etcd as config center

Posted by "ralf0131 (GitHub)" <gi...@apache.org>.
I found another problem. If I shutdown etcd server, the connection will be lost. And when I start etcd server again, and modify the key, the listener will no longer be notified.

[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3663 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [incubator-dubbo] codecov-io commented on issue #3663: [Dubbo-3653] etcd as config center

Posted by "codecov-io (GitHub)" <gi...@apache.org>.
# [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/3663?src=pr&el=h1) Report
> Merging [#3663](https://codecov.io/gh/apache/incubator-dubbo/pull/3663?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-dubbo/commit/9598cd09607b2dbe660ae16f4a95c79e107907a8?src=pr&el=desc) will **decrease** coverage by `0.06%`.
> The diff coverage is `0%`.

[![Impacted file tree graph](https://codecov.io/gh/apache/incubator-dubbo/pull/3663/graphs/tree.svg?width=650&token=VnEIkiFQT0&height=150&src=pr)](https://codecov.io/gh/apache/incubator-dubbo/pull/3663?src=pr&el=tree)

```diff
@@             Coverage Diff              @@
##             master    #3663      +/-   ##
============================================
- Coverage     63.94%   63.88%   -0.07%     
  Complexity       71       71              
============================================
  Files           699      699              
  Lines         30757    30768      +11     
  Branches       4989     4991       +2     
============================================
- Hits          19669    19655      -14     
- Misses         8824     8848      +24     
- Partials       2264     2265       +1
```


| [Impacted Files](https://codecov.io/gh/apache/incubator-dubbo/pull/3663?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../apache/dubbo/remoting/etcd/jetcd/JEtcdClient.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3663/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctZXRjZDMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JlbW90aW5nL2V0Y2QvamV0Y2QvSkV0Y2RDbGllbnQuamF2YQ==) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [.../dubbo/remoting/etcd/jetcd/JEtcdClientWrapper.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3663/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctZXRjZDMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JlbW90aW5nL2V0Y2QvamV0Y2QvSkV0Y2RDbGllbnRXcmFwcGVyLmphdmE=) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...ubbo/remoting/etcd/support/AbstractEtcdClient.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3663/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctZXRjZDMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JlbW90aW5nL2V0Y2Qvc3VwcG9ydC9BYnN0cmFjdEV0Y2RDbGllbnQuamF2YQ==) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...ache/dubbo/remoting/p2p/support/AbstractGroup.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3663/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctcDJwL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy9wMnAvc3VwcG9ydC9BYnN0cmFjdEdyb3VwLmphdmE=) | `45.45% <0%> (-11.37%)` | `0% <0%> (ø)` | |
| [...che/dubbo/remoting/transport/mina/MinaChannel.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3663/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctbWluYS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcmVtb3RpbmcvdHJhbnNwb3J0L21pbmEvTWluYUNoYW5uZWwuamF2YQ==) | `43.42% <0%> (-10.53%)` | `0% <0%> (ø)` | |
| [...dubbo/rpc/protocol/dubbo/CallbackServiceCodec.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3663/diff?src=pr&el=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1kdWJiby9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcnBjL3Byb3RvY29sL2R1YmJvL0NhbGxiYWNrU2VydmljZUNvZGVjLmphdmE=) | `76.47% <0%> (-2.21%)` | `0% <0%> (ø)` | |
| [...he/dubbo/registry/multicast/MulticastRegistry.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3663/diff?src=pr&el=tree#diff-ZHViYm8tcmVnaXN0cnkvZHViYm8tcmVnaXN0cnktbXVsdGljYXN0L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZWdpc3RyeS9tdWx0aWNhc3QvTXVsdGljYXN0UmVnaXN0cnkuamF2YQ==) | `67.87% <0%> (-1.81%)` | `0% <0%> (ø)` | |
| [...apache/dubbo/rpc/protocol/dubbo/DubboProtocol.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3663/diff?src=pr&el=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1kdWJiby9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcnBjL3Byb3RvY29sL2R1YmJvL0R1YmJvUHJvdG9jb2wuamF2YQ==) | `65.78% <0%> (-1.13%)` | `0% <0%> (ø)` | |
| [.../exchange/support/header/HeaderExchangeServer.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3663/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy9leGNoYW5nZS9zdXBwb3J0L2hlYWRlci9IZWFkZXJFeGNoYW5nZVNlcnZlci5qYXZh) | `66.98% <0%> (-0.95%)` | `0% <0%> (ø)` | |
| [...dubbo/remoting/exchange/support/DefaultFuture.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3663/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy9leGNoYW5nZS9zdXBwb3J0L0RlZmF1bHRGdXR1cmUuamF2YQ==) | `72.97% <0%> (ø)` | `0% <0%> (ø)` | :arrow_down: |
| ... and [4 more](https://codecov.io/gh/apache/incubator-dubbo/pull/3663/diff?src=pr&el=tree-more) | |

------

[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/3663?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/3663?src=pr&el=footer). Last update [9598cd0...8b2a26a](https://codecov.io/gh/apache/incubator-dubbo/pull/3663?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).


[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3663 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [incubator-dubbo] ralf0131 commented on issue #3663: [Dubbo-3653] etcd as config center

Posted by "ralf0131 (GitHub)" <gi...@apache.org>.
I have fixed the issue I found before, the new implementation will watch again when connection is established.

[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3663 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [incubator-dubbo] beiwei30 closed pull request #3663: [Dubbo-3653] etcd as config center

Posted by "beiwei30 (GitHub)" <gi...@apache.org>.
[ pull request closed by beiwei30 ]

[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3663 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [incubator-dubbo] codecov-io commented on issue #3663: [Dubbo-3653] etcd as config center

Posted by "codecov-io (GitHub)" <gi...@apache.org>.
# [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/3663?src=pr&el=h1) Report
> Merging [#3663](https://codecov.io/gh/apache/incubator-dubbo/pull/3663?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-dubbo/commit/9598cd09607b2dbe660ae16f4a95c79e107907a8?src=pr&el=desc) will **decrease** coverage by `0.06%`.
> The diff coverage is `0%`.

[![Impacted file tree graph](https://codecov.io/gh/apache/incubator-dubbo/pull/3663/graphs/tree.svg?width=650&token=VnEIkiFQT0&height=150&src=pr)](https://codecov.io/gh/apache/incubator-dubbo/pull/3663?src=pr&el=tree)

```diff
@@             Coverage Diff              @@
##             master    #3663      +/-   ##
============================================
- Coverage     63.94%   63.88%   -0.07%     
  Complexity       71       71              
============================================
  Files           699      699              
  Lines         30757    30768      +11     
  Branches       4989     4991       +2     
============================================
- Hits          19669    19657      -12     
- Misses         8824     8842      +18     
- Partials       2264     2269       +5
```


| [Impacted Files](https://codecov.io/gh/apache/incubator-dubbo/pull/3663?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../apache/dubbo/remoting/etcd/jetcd/JEtcdClient.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3663/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctZXRjZDMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JlbW90aW5nL2V0Y2QvamV0Y2QvSkV0Y2RDbGllbnQuamF2YQ==) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [.../dubbo/remoting/etcd/jetcd/JEtcdClientWrapper.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3663/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctZXRjZDMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JlbW90aW5nL2V0Y2QvamV0Y2QvSkV0Y2RDbGllbnRXcmFwcGVyLmphdmE=) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...ubbo/remoting/etcd/support/AbstractEtcdClient.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3663/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctZXRjZDMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JlbW90aW5nL2V0Y2Qvc3VwcG9ydC9BYnN0cmFjdEV0Y2RDbGllbnQuamF2YQ==) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...ache/dubbo/remoting/p2p/support/AbstractGroup.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3663/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctcDJwL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy9wMnAvc3VwcG9ydC9BYnN0cmFjdEdyb3VwLmphdmE=) | `45.45% <0%> (-11.37%)` | `0% <0%> (ø)` | |
| [.../apache/dubbo/remoting/transport/AbstractPeer.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3663/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy90cmFuc3BvcnQvQWJzdHJhY3RQZWVyLmphdmE=) | `63.04% <0%> (-8.7%)` | `0% <0%> (ø)` | |
| [...ng/exchange/support/header/HeartbeatTimerTask.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3663/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy9leGNoYW5nZS9zdXBwb3J0L2hlYWRlci9IZWFydGJlYXRUaW1lclRhc2suamF2YQ==) | `73.68% <0%> (-5.27%)` | `0% <0%> (ø)` | |
| [...dubbo/rpc/protocol/dubbo/CallbackServiceCodec.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3663/diff?src=pr&el=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1kdWJiby9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcnBjL3Byb3RvY29sL2R1YmJvL0NhbGxiYWNrU2VydmljZUNvZGVjLmphdmE=) | `76.47% <0%> (-2.21%)` | `0% <0%> (ø)` | |
| [...dubbo/remoting/exchange/support/DefaultFuture.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3663/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy9leGNoYW5nZS9zdXBwb3J0L0RlZmF1bHRGdXR1cmUuamF2YQ==) | `70.94% <0%> (-2.03%)` | `0% <0%> (ø)` | |
| [...he/dubbo/registry/multicast/MulticastRegistry.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3663/diff?src=pr&el=tree#diff-ZHViYm8tcmVnaXN0cnkvZHViYm8tcmVnaXN0cnktbXVsdGljYXN0L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZWdpc3RyeS9tdWx0aWNhc3QvTXVsdGljYXN0UmVnaXN0cnkuamF2YQ==) | `67.87% <0%> (-1.81%)` | `0% <0%> (ø)` | |
| [...apache/dubbo/rpc/protocol/dubbo/DubboProtocol.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3663/diff?src=pr&el=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1kdWJiby9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcnBjL3Byb3RvY29sL2R1YmJvL0R1YmJvUHJvdG9jb2wuamF2YQ==) | `65.78% <0%> (-1.13%)` | `0% <0%> (ø)` | |
| ... and [5 more](https://codecov.io/gh/apache/incubator-dubbo/pull/3663/diff?src=pr&el=tree-more) | |

------

[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/3663?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/3663?src=pr&el=footer). Last update [9598cd0...d1764c8](https://codecov.io/gh/apache/incubator-dubbo/pull/3663?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).


[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3663 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [incubator-dubbo] chickenlj commented on issue #3663: [Dubbo-3653] etcd as config center

Posted by "chickenlj (GitHub)" <gi...@apache.org>.
LGTM. My review focus on EtcdDynamicConfiguration.

I checked the following by running demos locally:
* can recover listeners after reconnect
* can get notified whenever updating or deleting happens
* other parts in EtcdDynamicConfiguration looks ok

[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3663 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [incubator-dubbo] zonghaishang commented on issue #3663: [Dubbo-3653] etcd as config center

Posted by "zonghaishang (GitHub)" <gi...@apache.org>.
I will check this week.

[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3663 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [incubator-dubbo] beiwei30 commented on issue #3663: [Dubbo-3653] etcd as config center

Posted by "beiwei30 (GitHub)" <gi...@apache.org>.
@zonghaishang I merged this pull request, but feel free to drop your review comments.

[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3663 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [incubator-dubbo] codecov-io commented on issue #3663: [Dubbo-3653] etcd as config center

Posted by "codecov-io (GitHub)" <gi...@apache.org>.
# [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/3663?src=pr&el=h1) Report
> Merging [#3663](https://codecov.io/gh/apache/incubator-dubbo/pull/3663?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-dubbo/commit/9598cd09607b2dbe660ae16f4a95c79e107907a8?src=pr&el=desc) will **decrease** coverage by `0.52%`.
> The diff coverage is `0%`.

[![Impacted file tree graph](https://codecov.io/gh/apache/incubator-dubbo/pull/3663/graphs/tree.svg?width=650&token=VnEIkiFQT0&height=150&src=pr)](https://codecov.io/gh/apache/incubator-dubbo/pull/3663?src=pr&el=tree)

```diff
@@             Coverage Diff              @@
##             master    #3663      +/-   ##
============================================
- Coverage     63.94%   63.42%   -0.53%     
  Complexity       71       71              
============================================
  Files           699      703       +4     
  Lines         30757    31000     +243     
  Branches       4989     5024      +35     
============================================
- Hits          19669    19663       -6     
- Misses         8824     9066     +242     
- Partials       2264     2271       +7
```


| [Impacted Files](https://codecov.io/gh/apache/incubator-dubbo/pull/3663?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ubbo/remoting/etcd/support/AbstractEtcdClient.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3663/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctZXRjZDMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JlbW90aW5nL2V0Y2Qvc3VwcG9ydC9BYnN0cmFjdEV0Y2RDbGllbnQuamF2YQ==) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [.../support/etcd/EtcdDynamicConfigurationFactory.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3663/diff?src=pr&el=tree#diff-ZHViYm8tY29uZmlnY2VudGVyL2R1YmJvLWNvbmZpZ2NlbnRlci1ldGNkL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb25maWdjZW50ZXIvc3VwcG9ydC9ldGNkL0V0Y2REeW5hbWljQ29uZmlndXJhdGlvbkZhY3RvcnkuamF2YQ==) | `0% <0%> (ø)` | `0 <0> (?)` | |
| [.../apache/dubbo/remoting/etcd/jetcd/JEtcdClient.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3663/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctZXRjZDMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JlbW90aW5nL2V0Y2QvamV0Y2QvSkV0Y2RDbGllbnQuamF2YQ==) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...a/org/apache/dubbo/registry/etcd/EtcdRegistry.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3663/diff?src=pr&el=tree#diff-ZHViYm8tcmVnaXN0cnkvZHViYm8tcmVnaXN0cnktZXRjZDMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JlZ2lzdHJ5L2V0Y2QvRXRjZFJlZ2lzdHJ5LmphdmE=) | `0% <0%> (ø)` | `0 <0> (?)` | |
| [...gcenter/support/etcd/EtcdDynamicConfiguration.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3663/diff?src=pr&el=tree#diff-ZHViYm8tY29uZmlnY2VudGVyL2R1YmJvLWNvbmZpZ2NlbnRlci1ldGNkL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb25maWdjZW50ZXIvc3VwcG9ydC9ldGNkL0V0Y2REeW5hbWljQ29uZmlndXJhdGlvbi5qYXZh) | `0% <0%> (ø)` | `0 <0> (?)` | |
| [.../dubbo/remoting/etcd/jetcd/JEtcdClientWrapper.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3663/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctZXRjZDMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JlbW90aW5nL2V0Y2QvamV0Y2QvSkV0Y2RDbGllbnRXcmFwcGVyLmphdmE=) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [.../apache/dubbo/remoting/transport/AbstractPeer.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3663/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy90cmFuc3BvcnQvQWJzdHJhY3RQZWVyLmphdmE=) | `63.04% <0%> (-8.7%)` | `0% <0%> (ø)` | |
| [...ng/exchange/support/header/HeartbeatTimerTask.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3663/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy9leGNoYW5nZS9zdXBwb3J0L2hlYWRlci9IZWFydGJlYXRUaW1lclRhc2suamF2YQ==) | `73.68% <0%> (-5.27%)` | `0% <0%> (ø)` | |
| [...bo/rpc/cluster/support/FailbackClusterInvoker.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3663/diff?src=pr&el=tree#diff-ZHViYm8tY2x1c3Rlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcnBjL2NsdXN0ZXIvc3VwcG9ydC9GYWlsYmFja0NsdXN0ZXJJbnZva2VyLmphdmE=) | `67.21% <0%> (-3.28%)` | `0% <0%> (ø)` | |
| [...dubbo/rpc/protocol/dubbo/CallbackServiceCodec.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3663/diff?src=pr&el=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1kdWJiby9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcnBjL3Byb3RvY29sL2R1YmJvL0NhbGxiYWNrU2VydmljZUNvZGVjLmphdmE=) | `76.47% <0%> (-2.21%)` | `0% <0%> (ø)` | |
| ... and [13 more](https://codecov.io/gh/apache/incubator-dubbo/pull/3663/diff?src=pr&el=tree-more) | |

------

[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/3663?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/3663?src=pr&el=footer). Last update [9598cd0...426cbae](https://codecov.io/gh/apache/incubator-dubbo/pull/3663?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).


[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3663 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [incubator-dubbo] chickenlj commented on issue #3663: [Dubbo-3653] etcd as config center

Posted by "chickenlj (GitHub)" <gi...@apache.org>.
You need to add `dubbo-configcenter-etcd` dependency into this file https://github.com/apache/incubator-dubbo/blob/master/dubbo-all/pom.xml, otherwise, it will not be packaged into dubbo-all.jar.

[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3663 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org