You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@atlas.apache.org by Sarath Subramanian <sa...@apache.org> on 2019/08/05 02:30:37 UTC
Re: Review Request 71127: ATLAS-3343: Ordering of dynAttr evaluation
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71127/#review217069
-----------------------------------------------------------
Fix it, then Ship it!
nice work on the topological sorting!
intg/src/main/java/org/apache/atlas/type/AtlasEntityType.java
Lines 1008 (patched)
<https://reviews.apache.org/r/71127/#comment304323>
createGraph() => createTokenAttributesMap()
intg/src/main/java/org/apache/atlas/type/AtlasEntityType.java
Lines 1050 (patched)
<https://reviews.apache.org/r/71127/#comment304322>
outVertex => tokenAttribute
- Sarath Subramanian
On July 25, 2019, 1:20 p.m., Merryle Wang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71127/
> -----------------------------------------------------------
>
> (Updated July 25, 2019, 1:20 p.m.)
>
>
> Review request for atlas, Ashutosh Mestry, Aadarsh Jajodia, Sridhar K, Le Ma, Madhan Neethiraj, and Sarath Subramanian.
>
>
> Repository: atlas
>
>
> Description
> -------
>
> ATLAS-3343: Ordering of dynAttr evaluation
>
>
> Diffs
> -----
>
> intg/src/main/java/org/apache/atlas/type/AtlasEntityType.java 23eaa0a2e88fd348d2347314170726ebb5cb4393
> intg/src/test/java/org/apache/atlas/type/TestAtlasEntityType.java c114bdf7888519cdd396fc8501bbcd92b00ef0bb
>
>
> Diff: https://reviews.apache.org/r/71127/diff/3/
>
>
> Testing
> -------
>
> Created dummy dynamic attributes to test the correct ordering.
>
>
> Thanks,
>
> Merryle Wang
>
>