You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lens.apache.org by Rajitha R <ra...@gmail.com> on 2017/12/08 08:12:16 UTC

Review Request 64443: Fix for TotalQueryCost [LENS-1493]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64443/
-----------------------------------------------------------

Review request for lens and Puneet Gupta.


Bugs: LENS-1493
    https://issues.apache.org/jira/browse/LENS-1493


Repository: lens


Description
-------

Changes include cost calculation being calculated by fetching each driver cost query cost values and summing it up.


Diffs
-----

  lens-server-api/src/main/java/org/apache/lens/server/api/query/cost/StaticQueryCost.java 8cdc254 
  lens-server/src/main/java/org/apache/lens/server/query/collect/DefaultEstimatedQueryCollection.java 9a37afd 
  lens-server/src/test/java/org/apache/lens/server/query/collect/DefaultEstimatedQueryCollectionTest.java 4dde18a 


Diff: https://reviews.apache.org/r/64443/diff/1/


Testing
-------


Thanks,

Rajitha R


Re: Review Request 64443: Fix for TotalQueryCost [LENS-1493]

Posted by Puneet Gupta <pu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64443/#review193651
-----------------------------------------------------------


Ship it!




Ship It!

- Puneet Gupta


On Dec. 12, 2017, 12:45 p.m., Rajitha R wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64443/
> -----------------------------------------------------------
> 
> (Updated Dec. 12, 2017, 12:45 p.m.)
> 
> 
> Review request for lens and Puneet Gupta.
> 
> 
> Bugs: LENS-1493
>     https://issues.apache.org/jira/browse/LENS-1493
> 
> 
> Repository: lens
> 
> 
> Description
> -------
> 
> Changes include cost calculation being calculated by fetching each driver cost query cost values and summing it up.
> 
> 
> Diffs
> -----
> 
>   lens-server-api/src/main/java/org/apache/lens/server/api/query/cost/StaticQueryCost.java 8cdc254 
>   lens-server/src/main/java/org/apache/lens/server/query/collect/DefaultEstimatedQueryCollection.java 9a37afd 
>   lens-server/src/test/java/org/apache/lens/server/query/collect/DefaultEstimatedQueryCollectionTest.java 4dde18a 
> 
> 
> Diff: https://reviews.apache.org/r/64443/diff/2/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Rajitha R
> 
>


Re: Review Request 64443: Fix for TotalQueryCost [LENS-1493]

Posted by Rajitha R <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64443/
-----------------------------------------------------------

(Updated Dec. 12, 2017, 12:45 p.m.)


Review request for lens and Puneet Gupta.


Bugs: LENS-1493
    https://issues.apache.org/jira/browse/LENS-1493


Repository: lens


Description
-------

Changes include cost calculation being calculated by fetching each driver cost query cost values and summing it up.


Diffs (updated)
-----

  lens-server-api/src/main/java/org/apache/lens/server/api/query/cost/StaticQueryCost.java 8cdc254 
  lens-server/src/main/java/org/apache/lens/server/query/collect/DefaultEstimatedQueryCollection.java 9a37afd 
  lens-server/src/test/java/org/apache/lens/server/query/collect/DefaultEstimatedQueryCollectionTest.java 4dde18a 


Diff: https://reviews.apache.org/r/64443/diff/2/

Changes: https://reviews.apache.org/r/64443/diff/1-2/


Testing
-------


Thanks,

Rajitha R