You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by "dongxiao1198 (via GitHub)" <gi...@apache.org> on 2025/11/28 09:04:33 UTC
[PR] test: test cpplint build [iceberg-cpp]
dongxiao1198 opened a new pull request, #362:
URL: https://github.com/apache/iceberg-cpp/pull/362
test: test cpplint build
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] fix: result.h cpplint failed after upgraded to gcc14 [iceberg-cpp]
Posted by "wgtmac (via GitHub)" <gi...@apache.org>.
wgtmac closed pull request #362: fix: result.h cpplint failed after upgraded to gcc14
URL: https://github.com/apache/iceberg-cpp/pull/362
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] fix: result.h cpplint failed after upgraded to gcc14 [iceberg-cpp]
Posted by "wgtmac (via GitHub)" <gi...@apache.org>.
wgtmac commented on PR #362:
URL: https://github.com/apache/iceberg-cpp/pull/362#issuecomment-3594434438
Thanks @HuaHuaY for investigation! Let me close this as it is fixed in another PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] fix: result.h cpplint failed after upgraded to gcc14 [iceberg-cpp]
Posted by "HuaHuaY (via GitHub)" <gi...@apache.org>.
HuaHuaY commented on PR #362:
URL: https://github.com/apache/iceberg-cpp/pull/362#issuecomment-3589332275
The reason for this problem is a bit complex:
1. Arrow cannot be compiled under C++23. So we set CMAKE_CXX_STANDARD 17 for arrow.
2. Clang-tidy itself believes that `result.h` might be included by arrow, so it reads the arrow's compilation commands through `compile_commands.json` and sees a `-std=c++17` flag in the compilation commands.
3. Clang-tidy assumes that `result.h` should also be compiled under C++17.
I think the solution to this problem is to force clang-tidy to compile under C++23. You can find my test PR #365. It compiles `result.h` successfully with cpp-linter `extra-args: '-std=c++23 ...'`.
I have opened a new PR #367 to fix this issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org