You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lenya.apache.org by Andreas Hartmann <an...@apache.org> on 2005/03/18 10:37:42 UTC

Re: svn commit: r158039 - in lenya/branches/BRANCH_1_2_X/src/java/org/apache/lenya/cms: cocoon/transformation/AccessControlSitetreeTransformer.java publication/AbstractPublication.java publication/DefaultSiteTree.java publication/Publication.java publication/SiteTree.java publication/SiteTreeNodeImpl.java

[...]

>  public interface SiteTree {
>  
> +    public static final String NAMESPACE_URI = "http://apache.org/cocoon/lenya/sitetree/1.0";


> +    public static final String SITE_TREE_FILENAME = "sitetree.xml";

This shouldn't be in the SiteTree interface. It is an implementation
detail that should be encapsulated. Furthermore, the file-based storage
is not a default for all sitetree implementations.

-- Andreas


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lenya.apache.org
For additional commands, e-mail: dev-help@lenya.apache.org

Re: svn commit: r158039 - in lenya/branches/BRANCH_1_2_X/src/java/org/apache/lenya/cms: cocoon/transformation/AccessControlSitetreeTransformer.java publication/AbstractPublication.java publication/DefaultSiteTree.java publication/Publication.java publication/SiteTree.java publication/SiteTreeNodeImpl.java

Posted by Michael Wechner <mi...@wyona.com>.
Andreas Hartmann wrote:

>
> [...]
>
>>  public interface SiteTree {
>>  
>> +    public static final String NAMESPACE_URI = 
>> "http://apache.org/cocoon/lenya/sitetree/1.0";
>
>
>
>> +    public static final String SITE_TREE_FILENAME = "sitetree.xml";
>
>
> This shouldn't be in the SiteTree interface. It is an implementation
> detail that should be encapsulated. Furthermore, the file-based storage
> is not a default for all sitetree implementations.


right, I moved this one back to the DefaultSiteTree

Thanks for poiting it out

Michi

>
> -- Andreas
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@lenya.apache.org
> For additional commands, e-mail: dev-help@lenya.apache.org
>
>


-- 
Michael Wechner
Wyona Inc.  -   Open Source Content Management   -   Apache Lenya
http://www.wyona.com                      http://lenya.apache.org
michael.wechner@wyona.com                        michi@apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lenya.apache.org
For additional commands, e-mail: dev-help@lenya.apache.org