You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/12/02 10:57:21 UTC

[GitHub] [airflow] ashb commented on a change in pull request #12467: Added support for DSS, ECDSA, and Ed25519 private keys in SSHHook

ashb commented on a change in pull request #12467:
URL: https://github.com/apache/airflow/pull/12467#discussion_r534076788



##########
File path: airflow/config_templates/config.yml
##########
@@ -2053,3 +2053,13 @@
       type: string
       example: ~
       default: "NamedHivePartitionSensor"
+- name: ssh
+  description: ~
+  options:
+    - name: private_keys_algorithm_support
+      description: |
+        Comma separated list of ssh algorithms names (following `ssh-keygen` naming) supported by
+        SSH hook
+      type: string
+      example: ~
+      default: "dsa,ecdsa,ed25519,rsa"

Review comment:
       This config value doesn't appear to be used anywhere.
   
   Either we should remove it, or use it. Given this needs a source-code change to add a new supported type, is there any value in having this config section?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org