You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/02/09 00:14:28 UTC

[GitHub] HeartSaVioR commented on issue #23304: [SPARK-26353][SQL]Add typed aggregate functions: max&&min

HeartSaVioR commented on issue #23304: [SPARK-26353][SQL]Add typed aggregate functions: max&&min
URL: https://github.com/apache/spark/pull/23304#issuecomment-461989879
 
 
   IMHO it would be ideal to have common aggregate functions for typed version as well (agree to restrict them to like sum/avg/count/min/max), otherwise end users using typed API have to implement such basic thing on their own.
   
   Btw, TODOs in source code are tend to being considered as things to contribute. Might be ideal to remove these false alarm once we don't see its needs.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org