You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@solr.apache.org by cp...@apache.org on 2022/09/20 14:18:20 UTC

[solr] 01/03: SOLR-16413: shorten long Grouping.searchWithTimeLimiter warnings (#796)

This is an automated email from the ASF dual-hosted git repository.

cpoerschke pushed a commit to branch branch_9x
in repository https://gitbox.apache.org/repos/asf/solr.git

commit 37f1a69739442ff61982b1b060a5cad2f8ca7b93
Author: Christine Poerschke <cp...@apache.org>
AuthorDate: Tue Sep 20 15:12:38 2022 +0100

    SOLR-16413: shorten long Grouping.searchWithTimeLimiter warnings (#796)
    
    (cherry picked from commit edf94abef30d207d19f56b642564d7274fca6d9b)
---
 solr/core/src/java/org/apache/solr/search/Grouping.java | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/solr/core/src/java/org/apache/solr/search/Grouping.java b/solr/core/src/java/org/apache/solr/search/Grouping.java
index 266cbdba196..0d28b7d4c6f 100644
--- a/solr/core/src/java/org/apache/solr/search/Grouping.java
+++ b/solr/core/src/java/org/apache/solr/search/Grouping.java
@@ -461,7 +461,10 @@ public class Grouping {
       searcher.search(QueryUtils.combineQueryAndFilter(query, filterQuery), collector);
     } catch (TimeLimitingCollector.TimeExceededException
         | ExitableDirectoryReader.ExitingReaderException x) {
-      log.warn("Query: {}; ", query, x);
+      // INFO log the (possibly quite long) query object separately
+      log.info("Query: {}; ", query);
+      // to make WARN logged exception content more visible
+      log.warn("Query: {}; ", query.getClass().getName(), x);
       qr.setPartialResults(true);
     }
   }