You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2022/04/22 08:32:45 UTC
[GitHub] [cloudstack] weizhouapache opened a new pull request, #6301: server: do not display 'Default Egress Policy' for vpc tiers
weizhouapache opened a new pull request, #6301:
URL: https://github.com/apache/cloudstack/pull/6301
### Description
This PR removes the 'Default Egress Policy' for vpc tiers.
The ingress/egress access of vpc tiers are controlled by network acl. the default egress policy is not applicable for vpc tiers.
therefore it would be better to remove it in api/ui.
<!--- Describe your changes in DETAIL - And how has behaviour functionally changed. -->
<!-- For new features, provide link to FS, dev ML discussion etc. -->
<!-- In case of bug fix, the expected and actual behaviours, steps to reproduce. -->
<!-- When "Fixes: #<id>" is specified, the issue/PR will automatically be closed when this PR gets merged -->
<!-- For addressing multiple issues/PRs, use multiple "Fixes: #<id>" -->
<!-- Fixes: # -->
<!--- ********************************************************************************* -->
<!--- NOTE: AUTOMATATION USES THE DESCRIPTIONS TO SET LABELS AND PRODUCE DOCUMENTATION. -->
<!--- PLEASE PUT AN 'X' in only **ONE** box -->
<!--- ********************************************************************************* -->
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [x] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
### Feature/Enhancement Scale or Bug Severity
#### Feature/Enhancement Scale
- [ ] Major
- [ ] Minor
#### Bug Severity
- [ ] BLOCKER
- [ ] Critical
- [ ] Major
- [x] Minor
- [ ] Trivial
### Screenshots (if appropriate):
### How Has This Been Tested?
<!-- Please describe in detail how you tested your changes. -->
<!-- Include details of your testing environment, and the tests you ran to -->
<!-- see how your change affects other areas of the code, etc. -->
<!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/main/CONTRIBUTING.md) document -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] acs-robot commented on pull request #6301: server: do not display 'Default Egress Policy' for vpc tiers
Posted by GitBox <gi...@apache.org>.
acs-robot commented on PR #6301:
URL: https://github.com/apache/cloudstack/pull/6301#issuecomment-1106225411
## PR Coverage Report
|**CLASS**|**INSTRUCTION MISSED**|**INSTRUCTION COVERED**|**BRANCH MISSED**|**BRANCH COVERED**|**LINE MISSED**|**LINE COVERED**|
|-----|-----|-----|-----|-----|-----|-----|
|ApiResponseHelper|12147|0|1276|0|2779|0|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on pull request #6301: server: do not display 'Default Egress Policy' for vpc tiers
Posted by GitBox <gi...@apache.org>.
weizhouapache commented on PR #6301:
URL: https://github.com/apache/cloudstack/pull/6301#issuecomment-1106363366
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez commented on pull request #6301: server: do not display 'Default Egress Policy' for vpc tiers
Posted by GitBox <gi...@apache.org>.
nvazquez commented on PR #6301:
URL: https://github.com/apache/cloudstack/pull/6301#issuecomment-1106442041
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6301: server: do not display 'Default Egress Policy' for vpc tiers
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6301:
URL: https://github.com/apache/cloudstack/pull/6301#issuecomment-1106363799
@weizhouapache a Jenkins job has been kicked to build packages. It will be bundled with
SystemVM template(s). I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on pull request #6301: server: do not display 'Default Egress Policy' for vpc tiers
Posted by GitBox <gi...@apache.org>.
weizhouapache commented on PR #6301:
URL: https://github.com/apache/cloudstack/pull/6301#issuecomment-1106195491
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez closed pull request #6301: server: do not display 'Default Egress Policy' for vpc tiers
Posted by GitBox <gi...@apache.org>.
nvazquez closed pull request #6301: server: do not display 'Default Egress Policy' for vpc tiers
URL: https://github.com/apache/cloudstack/pull/6301
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6301: server: do not display 'Default Egress Policy' for vpc tiers
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6301:
URL: https://github.com/apache/cloudstack/pull/6301#issuecomment-1106426783
Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_multiplication_x: suse15. SL-JID 3274
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez merged pull request #6301: server: do not display 'Default Egress Policy' for vpc tiers
Posted by GitBox <gi...@apache.org>.
nvazquez merged PR #6301:
URL: https://github.com/apache/cloudstack/pull/6301
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6301: server: do not display 'Default Egress Policy' for vpc tiers
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6301:
URL: https://github.com/apache/cloudstack/pull/6301#issuecomment-1107116986
<b>Trillian test result (tid-3996)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 45459 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6301-t3996-kvm-centos7.zip
Smoke tests completed. 89 look OK, 1 have errors
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
ContextSuite context=TestAccounts>:setup | `Error` | 0.00 | test_accounts.py
ContextSuite context=TestAddVmToSubDomain>:setup | `Error` | 0.00 | test_accounts.py
test_DeleteDomain | `Error` | 6.14 | test_accounts.py
test_forceDeleteDomain | `Failure` | 6.21 | test_accounts.py
ContextSuite context=TestRemoveUserFromAccount>:setup | `Error` | 7.43 | test_accounts.py
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6301: server: do not display 'Default Egress Policy' for vpc tiers
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6301:
URL: https://github.com/apache/cloudstack/pull/6301#issuecomment-1106442661
@nvazquez a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org