You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/10/18 10:23:24 UTC

[GitHub] [flink] LadyForest opened a new pull request, #21097: [FLINK-29677] DROP CATALOG statement does not reset current catalog

LadyForest opened a new pull request, #21097:
URL: https://github.com/apache/flink/pull/21097

   ## What is the purpose of the change
   
   This pull request fixes the issue that when dropping a catalog in use, the following `SHOW CURRENT CATALOG` still displays the dropped catalog by preventing users from dropping a catalog in use.
   
   ## Brief change log
   Let `CatalogManager#unregisterCatalog` throws `CatalogException` when dropping a catalog in use.
   
   
   ## Verifying this change
   This change is a trivial rework and can be verified as follows:
   - `CatalogITCase#testDropCatalog`
   - `TableEnvironmentTest#testExecuteSqlWithCreateUseDropCatalog`
   - `catalog_database.q` which executed by `ClientITCase`
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): no
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
     - The serializers: no
     - The runtime per-record code paths (performance sensitive): no
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
     - The S3 file system connector: no
   
   ## Documentation
     - Does this pull request introduces a new feature? no
     - If yes, how is the feature documented? not applicable
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] fsk119 closed pull request #21097: [FLINK-29677] DROP CATALOG statement does not reset current catalog

Posted by GitBox <gi...@apache.org>.
fsk119 closed pull request #21097: [FLINK-29677] DROP CATALOG statement does not reset current catalog
URL: https://github.com/apache/flink/pull/21097


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #21097: [FLINK-29677] DROP CATALOG statement does not reset current catalog

Posted by GitBox <gi...@apache.org>.
flinkbot commented on PR #21097:
URL: https://github.com/apache/flink/pull/21097#issuecomment-1282178271

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "d94f6ca0eef826afee7ed2b186f8bb5b537a1e79",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "d94f6ca0eef826afee7ed2b186f8bb5b537a1e79",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * d94f6ca0eef826afee7ed2b186f8bb5b537a1e79 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] LadyForest commented on pull request #21097: [FLINK-29677] DROP CATALOG statement does not reset current catalog

Posted by GitBox <gi...@apache.org>.
LadyForest commented on PR #21097:
URL: https://github.com/apache/flink/pull/21097#issuecomment-1283370296

   Hi @fsk119, do you have time to take a look?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org