[GitHub] [geode] pivotal-jbarrett commented on a diff in pull request #7665: GEODE-10281: Fix WAN data inconsistency

[GitBox <gi...@apache.org>]

pivotal-jbarrett commented on code in PR #7665:
URL: https://github.com/apache/geode/pull/7665#discussion_r891801945


##########
geode-wan/src/distributedTest/java/org/apache/geode/internal/cache/wan/serial/TestCacheWriterDelayWritingOfEntry.java:
##########
@@ -0,0 +1,82 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more contributor license
+ * agreements. See the NOTICE file distributed with this work for additional information regarding
+ * copyright ownership. The ASF licenses this file to You under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance with the License. You may obtain a
+ * copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software distributed under the License
+ * is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express
+ * or implied. See the License for the specific language governing permissions and limitations under
+ * the License.
+ */
+package org.apache.geode.internal.cache.wan.serial;
+
+import static org.apache.geode.test.awaitility.GeodeAwaitility.await;
+import static org.assertj.core.api.Assertions.assertThat;
+
+import java.util.Map;
+
+import org.apache.geode.cache.CacheWriter;
+import org.apache.geode.cache.CacheWriterException;
+import org.apache.geode.cache.EntryEvent;
+import org.apache.geode.cache.Region;
+import org.apache.geode.cache.RegionEvent;
+import org.apache.geode.test.dunit.rules.ClusterStartupRule;
+
+public class TestCacheWriterDelayWritingOfEntry<K, V> implements CacheWriter<K, V> {

Review Comment:
   nit: If this test class is only going to be used by the single test suite then perhaps it should be nested type rather than a top level.



##########
geode-core/src/test/java/org/apache/geode/internal/cache/wan/GatewaySenderEventImplTest.java:
##########
@@ -377,6 +377,37 @@ public void testCreation_WithAfterUpdateWithGenerateCallbacks(boolean isGenerate
     assertThat(event.getAction()).isEqualTo(action);
   }
 
+  @Test

Review Comment:
   Convert this unit test to use JUnit 5.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org