You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@carbondata.apache.org by mohammadshahidkhan <gi...@git.apache.org> on 2017/07/10 12:20:55 UTC
[GitHub] carbondata pull request #1155: [CARBONDATA-1283] Carbon should continue with...
GitHub user mohammadshahidkhan opened a pull request:
https://github.com/apache/carbondata/pull/1155
[CARBONDATA-1283] Carbon should continue with the default value if wrong value is configured for the property
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mohammadshahidkhan/incubator-carbondata correctfailovertodefaultconfforinvalid
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/carbondata/pull/1155.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1155
----
commit 7bbb50300bae042810c3c19a862f7b25d5490430
Author: mohammadshahidkhan <mo...@gmail.com>
Date: 2017-07-10T12:17:16Z
[CARBONDATA-1283] Carbon should continue with the default value if wrong value is configured for the property
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] carbondata issue #1155: [CARBONDATA-1283] Carbon should continue with the de...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit commented on the issue:
https://github.com/apache/carbondata/pull/1155
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] carbondata issue #1155: [CARBONDATA-1283] Carbon should continue with the de...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1155
Build Success with Spark 1.6, Please check CI http://144.76.159.231:8080/job/ApacheCarbonPRBuilder/448/
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] carbondata pull request #1155: [CARBONDATA-1283] Carbon should continue with...
Posted by gvramana <gi...@git.apache.org>.
Github user gvramana commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1155#discussion_r126867396
--- Diff: core/src/main/java/org/apache/carbondata/core/constants/CarbonCommonConstants.java ---
@@ -329,6 +329,15 @@
*/
public static final String CSV_READ_BUFFER_SIZE_DEFAULT = "50000";
/**
+ * min value for csv read buffer size
+ */
+ public static final int CSV_READ_BUFFER_SIZE_MIN = 10240; //10 kb
+ /**
+ * max value for csv read buffer size
+ */
+ public static final int CSV_READ_BUFFER_SIZE_MAX = 10485760; // 10 mb
--- End diff --
This size can be 100mb.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] carbondata issue #1155: [CARBONDATA-1283] Carbon should continue with the de...
Posted by gvramana <gi...@git.apache.org>.
Github user gvramana commented on the issue:
https://github.com/apache/carbondata/pull/1155
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] carbondata issue #1155: [CARBONDATA-1283] Carbon should continue with the de...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1155
Build Success with Spark 1.6, Please check CI http://144.76.159.231:8080/job/ApacheCarbonPRBuilder/404/
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] carbondata issue #1155: [CARBONDATA-1283] Carbon should continue with the de...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1155
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder/2993/
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] carbondata pull request #1155: [CARBONDATA-1283] Carbon should continue with...
Posted by gvramana <gi...@git.apache.org>.
Github user gvramana commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1155#discussion_r126867170
--- Diff: core/src/main/java/org/apache/carbondata/core/util/CarbonProperties.java ---
@@ -98,6 +100,119 @@ private void validateAndLoadDefaultProperties() {
validateBlockletGroupSizeInMB();
validateNumberOfColumnPerIORead();
validateNumberOfRowsPerBlockletColumnPage();
+ validateEnableUnsafeSort();
+ validateCustomBlockDistribution();
+ validateEnableVectorReader();
+ validateLockType();
+ validateCarbonCSVReadBufferSizeByte();
+ }
+
+ private void validateCarbonCSVReadBufferSizeByte() {
+ String csvReadBufferSizeStr =
+ carbonProperties.getProperty(CarbonCommonConstants.CSV_READ_BUFFER_SIZE);
+ if (null != csvReadBufferSizeStr) {
+ try {
+ int bufferSize = Integer.parseInt(csvReadBufferSizeStr);
+ if (bufferSize < CarbonCommonConstants.CSV_READ_BUFFER_SIZE_MIN
+ || bufferSize > CarbonCommonConstants.CSV_READ_BUFFER_SIZE_MAX) {
+ LOGGER.warn("The value \"" + csvReadBufferSizeStr + "\" configured for key "
+ + CarbonCommonConstants.CSV_READ_BUFFER_SIZE
+ + "\" is not in range. Valid range us (byte) \""
+ + CarbonCommonConstants.CSV_READ_BUFFER_SIZE_MIN + " to \""
+ + CarbonCommonConstants.CSV_READ_BUFFER_SIZE_MAX + ". Using the default value \""
+ + CarbonCommonConstants.CSV_READ_BUFFER_SIZE_DEFAULT);
+ carbonProperties.setProperty(CarbonCommonConstants.CSV_READ_BUFFER_SIZE,
+ CarbonCommonConstants.CSV_READ_BUFFER_SIZE_DEFAULT);
+ }
+ } catch (NumberFormatException nfe) {
+ LOGGER.warn("The value \"" + csvReadBufferSizeStr + "\" configured for key "
+ + CarbonCommonConstants.CSV_READ_BUFFER_SIZE
+ + "\" is invalid. Using the default value \""
+ + CarbonCommonConstants.CSV_READ_BUFFER_SIZE_DEFAULT);
+ carbonProperties.setProperty(CarbonCommonConstants.CSV_READ_BUFFER_SIZE,
+ CarbonCommonConstants.CSV_READ_BUFFER_SIZE_DEFAULT);
+ }
+ }
+ }
+
+ private void validateLockType() {
+ String lockTypeConfigured = carbonProperties.getProperty(CarbonCommonConstants.LOCK_TYPE);
+ if (null != lockTypeConfigured) {
+ switch (lockTypeConfigured.toUpperCase()) {
+ case CarbonCommonConstants.CARBON_LOCK_TYPE_LOCAL:
+ case CarbonCommonConstants.CARBON_LOCK_TYPE_ZOOKEEPER:
+ case CarbonCommonConstants.CARBON_LOCK_TYPE_HDFS:
+ break;
+ default:
+ configureDefaultLockType(lockTypeConfigured);
+ }
+ } else {
+ configureDefaultLockType(lockTypeConfigured);
+ }
+ }
+
+ /**
+ * the method decide and set the lock type based on the configured system type
+ *
+ * @param lockTypeConfigured
+ */
+ private void configureDefaultLockType(String lockTypeConfigured) {
+ Configuration configuration = new Configuration(true);
+ String defaultFs = configuration.get("fs.defaultFS");
--- End diff --
How about the case when default.fs is hdfs but carbon store path is configured as local file path.
Alluxio fs what is behaviour of locking?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] carbondata issue #1155: [CARBONDATA-1283] Carbon should continue with the de...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1155
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder/3035/
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] carbondata pull request #1155: [CARBONDATA-1283] Carbon should continue with...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/carbondata/pull/1155
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] carbondata issue #1155: [CARBONDATA-1283] Carbon should continue with the de...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1155
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder/3036/
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] carbondata issue #1155: [CARBONDATA-1283] Carbon should continue with the de...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1155
Build Failed with Spark 1.6, Please check CI http://144.76.159.231:8080/job/ApacheCarbonPRBuilder/432/
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] carbondata issue #1155: [CARBONDATA-1283] Carbon should continue with the de...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1155
Build Success with Spark 1.6, Please check CI http://144.76.159.231:8080/job/ApacheCarbonPRBuilder/447/
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] carbondata issue #1155: [CARBONDATA-1283] Carbon should continue with the de...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1155
Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder/3020/
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---