You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Aravindan Vijayan <av...@hortonworks.com> on 2017/11/27 18:34:24 UTC

Review Request 64088: AMBARI-22524 : Journal Node start failing when AMS is installed during BP deploy

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64088/
-----------------------------------------------------------

Review request for Ambari, Dmytro Sen, Jayush Luniya, and Sid Wagle.


Bugs: AMBARI-22524
    https://issues.apache.org/jira/browse/AMBARI-22524


Repository: ambari


Description
-------

Journal Node start failing when AMS is installed during BP deploy

JN logs:

{code:java}
2017-11-17 23:07:10,236 INFO  impl.MetricsConfig (MetricsConfig.java:loadFirst(121)) - loaded properties from hadoop-metrics2.properties
2017-11-17 23:07:10,529 ERROR server.JournalNode (JournalNode.java:main(373)) - Failed to start journalnode.
java.lang.AbstractMethodError: org.apache.hadoop.metrics2.sink.timeline.HadoopTimelineMetricsSink.init(Lorg/apache/commons/configuration2/SubsetConfiguration;)V
        at org.apache.hadoop.metrics2.impl.MetricsConfig.getPlugin(MetricsConfig.java:208)
        at org.apache.hadoop.metrics2.impl.MetricsSystemImpl.newSink(MetricsSystemImpl.java:531)
        at org.apache.hadoop.metrics2.impl.MetricsSystemImpl.configureSinks(MetricsSystemImpl.java:503)
        at org.apache.hadoop.metrics2.impl.MetricsSystemImpl.configure(MetricsSystemImpl.java:479)
        at org.apache.hadoop.metrics2.impl.MetricsSystemImpl.start(MetricsSystemImpl.java:188)
        at org.apache.hadoop.metrics2.impl.MetricsSystemImpl.init(MetricsSystemImpl.java:163)
        at org.apache.hadoop.metrics2.lib.DefaultMetricsSystem.init(DefaultMetricsSystem.java:62)
        at org.apache.hadoop.metrics2.lib.DefaultMetricsSystem.initialize(DefaultMetricsSystem.java:58)
        at org.apache.hadoop.hdfs.qjournal.server.JournalNode.start(JournalNode.java:191)
        at org.apache.hadoop.hdfs.qjournal.server.JournalNode.run(JournalNode.java:177)
        at org.apache.hadoop.util.ToolRunner.run(ToolRunner.java:76)
        at org.apache.hadoop.util.ToolRunner.run(ToolRunner.java:90)
        at org.apache.hadoop.hdfs.qjournal.server.JournalNode.main(JournalNode.java:371)
2017-11-17 23:07:10,534 INFO  util.ExitUtil (ExitUtil.java:terminate(210)) - Exiting with status -1: java.lang.AbstractMethodError: org.apache.hadoop.metrics2.sink.timeline.HadoopTimelineMetricsSink.init(Lorg/apache/commons/configuration2/SubsetConfiguration;)V
{code}


Diffs
-----

  ambari-metrics/ambari-metrics-hadoop-sink/pom.xml 23f9ba9 
  ambari-metrics/ambari-metrics-hadoop-sink/src/main/java/org/apache/hadoop/metrics2/sink/timeline/HadoopTimelineMetricsSink.java a290ced 
  ambari-metrics/ambari-metrics-hadoop-sink/src/test/java/org/apache/hadoop/metrics2/sink/timeline/HadoopTimelineMetricsSinkTest.java 30c5c23 
  ambari-metrics/pom.xml a14b8fd 


Diff: https://reviews.apache.org/r/64088/diff/1/


Testing
-------

Manually tested.
Unit tests pass.


Thanks,

Aravindan Vijayan


Re: Review Request 64088: AMBARI-22524 : Journal Node start failing when AMS is installed during BP deploy

Posted by Sid Wagle <sw...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64088/#review191916
-----------------------------------------------------------


Fix it, then Ship it!





ambari-metrics/ambari-metrics-hadoop-sink/pom.xml
Line 144 (original), 144 (patched)
<https://reviews.apache.org/r/64088/#comment269850>

    This should be parameterized to be configurable by build scripts.


- Sid Wagle


On Nov. 27, 2017, 6:34 p.m., Aravindan Vijayan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64088/
> -----------------------------------------------------------
> 
> (Updated Nov. 27, 2017, 6:34 p.m.)
> 
> 
> Review request for Ambari, Dmytro Sen, Jayush Luniya, and Sid Wagle.
> 
> 
> Bugs: AMBARI-22524
>     https://issues.apache.org/jira/browse/AMBARI-22524
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Journal Node start failing when AMS is installed during BP deploy
> 
> JN logs:
> 
> {code:java}
> 2017-11-17 23:07:10,236 INFO  impl.MetricsConfig (MetricsConfig.java:loadFirst(121)) - loaded properties from hadoop-metrics2.properties
> 2017-11-17 23:07:10,529 ERROR server.JournalNode (JournalNode.java:main(373)) - Failed to start journalnode.
> java.lang.AbstractMethodError: org.apache.hadoop.metrics2.sink.timeline.HadoopTimelineMetricsSink.init(Lorg/apache/commons/configuration2/SubsetConfiguration;)V
>         at org.apache.hadoop.metrics2.impl.MetricsConfig.getPlugin(MetricsConfig.java:208)
>         at org.apache.hadoop.metrics2.impl.MetricsSystemImpl.newSink(MetricsSystemImpl.java:531)
>         at org.apache.hadoop.metrics2.impl.MetricsSystemImpl.configureSinks(MetricsSystemImpl.java:503)
>         at org.apache.hadoop.metrics2.impl.MetricsSystemImpl.configure(MetricsSystemImpl.java:479)
>         at org.apache.hadoop.metrics2.impl.MetricsSystemImpl.start(MetricsSystemImpl.java:188)
>         at org.apache.hadoop.metrics2.impl.MetricsSystemImpl.init(MetricsSystemImpl.java:163)
>         at org.apache.hadoop.metrics2.lib.DefaultMetricsSystem.init(DefaultMetricsSystem.java:62)
>         at org.apache.hadoop.metrics2.lib.DefaultMetricsSystem.initialize(DefaultMetricsSystem.java:58)
>         at org.apache.hadoop.hdfs.qjournal.server.JournalNode.start(JournalNode.java:191)
>         at org.apache.hadoop.hdfs.qjournal.server.JournalNode.run(JournalNode.java:177)
>         at org.apache.hadoop.util.ToolRunner.run(ToolRunner.java:76)
>         at org.apache.hadoop.util.ToolRunner.run(ToolRunner.java:90)
>         at org.apache.hadoop.hdfs.qjournal.server.JournalNode.main(JournalNode.java:371)
> 2017-11-17 23:07:10,534 INFO  util.ExitUtil (ExitUtil.java:terminate(210)) - Exiting with status -1: java.lang.AbstractMethodError: org.apache.hadoop.metrics2.sink.timeline.HadoopTimelineMetricsSink.init(Lorg/apache/commons/configuration2/SubsetConfiguration;)V
> {code}
> 
> 
> Diffs
> -----
> 
>   ambari-metrics/ambari-metrics-hadoop-sink/pom.xml 23f9ba9 
>   ambari-metrics/ambari-metrics-hadoop-sink/src/main/java/org/apache/hadoop/metrics2/sink/timeline/HadoopTimelineMetricsSink.java a290ced 
>   ambari-metrics/ambari-metrics-hadoop-sink/src/test/java/org/apache/hadoop/metrics2/sink/timeline/HadoopTimelineMetricsSinkTest.java 30c5c23 
>   ambari-metrics/pom.xml a14b8fd 
> 
> 
> Diff: https://reviews.apache.org/r/64088/diff/1/
> 
> 
> Testing
> -------
> 
> Manually tested.
> Unit tests pass.
> 
> 
> Thanks,
> 
> Aravindan Vijayan
> 
>


Re: Review Request 64088: AMBARI-22524 : Journal Node start failing when AMS is installed during BP deploy

Posted by Dmytro Sen <ds...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64088/#review192008
-----------------------------------------------------------


Ship it!




Ship It!

- Dmytro Sen


On Nov. 27, 2017, 6:54 p.m., Aravindan Vijayan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64088/
> -----------------------------------------------------------
> 
> (Updated Nov. 27, 2017, 6:54 p.m.)
> 
> 
> Review request for Ambari, Dmytro Sen, Jayush Luniya, and Sid Wagle.
> 
> 
> Bugs: AMBARI-22524
>     https://issues.apache.org/jira/browse/AMBARI-22524
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Journal Node start failing when AMS is installed during BP deploy
> 
> JN logs:
> 
> {code:java}
> 2017-11-17 23:07:10,236 INFO  impl.MetricsConfig (MetricsConfig.java:loadFirst(121)) - loaded properties from hadoop-metrics2.properties
> 2017-11-17 23:07:10,529 ERROR server.JournalNode (JournalNode.java:main(373)) - Failed to start journalnode.
> java.lang.AbstractMethodError: org.apache.hadoop.metrics2.sink.timeline.HadoopTimelineMetricsSink.init(Lorg/apache/commons/configuration2/SubsetConfiguration;)V
>         at org.apache.hadoop.metrics2.impl.MetricsConfig.getPlugin(MetricsConfig.java:208)
>         at org.apache.hadoop.metrics2.impl.MetricsSystemImpl.newSink(MetricsSystemImpl.java:531)
>         at org.apache.hadoop.metrics2.impl.MetricsSystemImpl.configureSinks(MetricsSystemImpl.java:503)
>         at org.apache.hadoop.metrics2.impl.MetricsSystemImpl.configure(MetricsSystemImpl.java:479)
>         at org.apache.hadoop.metrics2.impl.MetricsSystemImpl.start(MetricsSystemImpl.java:188)
>         at org.apache.hadoop.metrics2.impl.MetricsSystemImpl.init(MetricsSystemImpl.java:163)
>         at org.apache.hadoop.metrics2.lib.DefaultMetricsSystem.init(DefaultMetricsSystem.java:62)
>         at org.apache.hadoop.metrics2.lib.DefaultMetricsSystem.initialize(DefaultMetricsSystem.java:58)
>         at org.apache.hadoop.hdfs.qjournal.server.JournalNode.start(JournalNode.java:191)
>         at org.apache.hadoop.hdfs.qjournal.server.JournalNode.run(JournalNode.java:177)
>         at org.apache.hadoop.util.ToolRunner.run(ToolRunner.java:76)
>         at org.apache.hadoop.util.ToolRunner.run(ToolRunner.java:90)
>         at org.apache.hadoop.hdfs.qjournal.server.JournalNode.main(JournalNode.java:371)
> 2017-11-17 23:07:10,534 INFO  util.ExitUtil (ExitUtil.java:terminate(210)) - Exiting with status -1: java.lang.AbstractMethodError: org.apache.hadoop.metrics2.sink.timeline.HadoopTimelineMetricsSink.init(Lorg/apache/commons/configuration2/SubsetConfiguration;)V
> {code}
> 
> 
> Diffs
> -----
> 
>   ambari-metrics/ambari-metrics-hadoop-sink/pom.xml 23f9ba9 
>   ambari-metrics/ambari-metrics-hadoop-sink/src/main/java/org/apache/hadoop/metrics2/sink/timeline/HadoopTimelineMetricsSink.java a290ced 
>   ambari-metrics/ambari-metrics-hadoop-sink/src/test/java/org/apache/hadoop/metrics2/sink/timeline/HadoopTimelineMetricsSinkTest.java 30c5c23 
> 
> 
> Diff: https://reviews.apache.org/r/64088/diff/2/
> 
> 
> Testing
> -------
> 
> Manually tested.
> Unit tests pass.
> 
> 
> Thanks,
> 
> Aravindan Vijayan
> 
>


Re: Review Request 64088: AMBARI-22524 : Journal Node start failing when AMS is installed during BP deploy

Posted by Aravindan Vijayan <av...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64088/
-----------------------------------------------------------

(Updated Nov. 27, 2017, 6:54 p.m.)


Review request for Ambari, Dmytro Sen, Jayush Luniya, and Sid Wagle.


Bugs: AMBARI-22524
    https://issues.apache.org/jira/browse/AMBARI-22524


Repository: ambari


Description
-------

Journal Node start failing when AMS is installed during BP deploy

JN logs:

{code:java}
2017-11-17 23:07:10,236 INFO  impl.MetricsConfig (MetricsConfig.java:loadFirst(121)) - loaded properties from hadoop-metrics2.properties
2017-11-17 23:07:10,529 ERROR server.JournalNode (JournalNode.java:main(373)) - Failed to start journalnode.
java.lang.AbstractMethodError: org.apache.hadoop.metrics2.sink.timeline.HadoopTimelineMetricsSink.init(Lorg/apache/commons/configuration2/SubsetConfiguration;)V
        at org.apache.hadoop.metrics2.impl.MetricsConfig.getPlugin(MetricsConfig.java:208)
        at org.apache.hadoop.metrics2.impl.MetricsSystemImpl.newSink(MetricsSystemImpl.java:531)
        at org.apache.hadoop.metrics2.impl.MetricsSystemImpl.configureSinks(MetricsSystemImpl.java:503)
        at org.apache.hadoop.metrics2.impl.MetricsSystemImpl.configure(MetricsSystemImpl.java:479)
        at org.apache.hadoop.metrics2.impl.MetricsSystemImpl.start(MetricsSystemImpl.java:188)
        at org.apache.hadoop.metrics2.impl.MetricsSystemImpl.init(MetricsSystemImpl.java:163)
        at org.apache.hadoop.metrics2.lib.DefaultMetricsSystem.init(DefaultMetricsSystem.java:62)
        at org.apache.hadoop.metrics2.lib.DefaultMetricsSystem.initialize(DefaultMetricsSystem.java:58)
        at org.apache.hadoop.hdfs.qjournal.server.JournalNode.start(JournalNode.java:191)
        at org.apache.hadoop.hdfs.qjournal.server.JournalNode.run(JournalNode.java:177)
        at org.apache.hadoop.util.ToolRunner.run(ToolRunner.java:76)
        at org.apache.hadoop.util.ToolRunner.run(ToolRunner.java:90)
        at org.apache.hadoop.hdfs.qjournal.server.JournalNode.main(JournalNode.java:371)
2017-11-17 23:07:10,534 INFO  util.ExitUtil (ExitUtil.java:terminate(210)) - Exiting with status -1: java.lang.AbstractMethodError: org.apache.hadoop.metrics2.sink.timeline.HadoopTimelineMetricsSink.init(Lorg/apache/commons/configuration2/SubsetConfiguration;)V
{code}


Diffs (updated)
-----

  ambari-metrics/ambari-metrics-hadoop-sink/pom.xml 23f9ba9 
  ambari-metrics/ambari-metrics-hadoop-sink/src/main/java/org/apache/hadoop/metrics2/sink/timeline/HadoopTimelineMetricsSink.java a290ced 
  ambari-metrics/ambari-metrics-hadoop-sink/src/test/java/org/apache/hadoop/metrics2/sink/timeline/HadoopTimelineMetricsSinkTest.java 30c5c23 


Diff: https://reviews.apache.org/r/64088/diff/2/

Changes: https://reviews.apache.org/r/64088/diff/1-2/


Testing
-------

Manually tested.
Unit tests pass.


Thanks,

Aravindan Vijayan