[GitHub] [spark] cloud-fan commented on pull request #42837: [WIP] enforce Window#windowExpressions to be window expressions only

["cloud-fan (via GitHub)" <gi...@apache.org>]

cloud-fan commented on PR #42837:
URL: https://github.com/apache/spark/pull/42837#issuecomment-1715688007

   In the rule `DecimalAggregates`, we need to rewrite `WindowExpression(...)` to `MakeDecimal(WindowExpression(...), ...)`, and it's more convenient if the `Window` logical plan can host more than just `WindowExpression`. I'm closing this PR.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org