You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Jiang Yan Xu <ya...@jxu.me> on 2015/09/19 00:13:59 UTC
Review Request 38511: Added a warning comment to the copy provisioner
backend.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38511/
-----------------------------------------------------------
Review request for mesos, Jie Yu, Jojy Varghese, and Timothy Chen.
Repository: mesos
Description
-------
- We should investigate how to resolve these implications or disable/discourage the use of this backend in production after the overlay backend is committed.
Diffs
-----
src/slave/containerizer/provisioner/backends/copy.hpp 10d9aee8c69e29e0cc9848fc5bde9919d0732b09
Diff: https://reviews.apache.org/r/38511/diff/
Testing
-------
N/A.
Thanks,
Jiang Yan Xu
Re: Review Request 38511: Added a warning comment to the copy
provisioner backend.
Posted by Jiang Yan Xu <ya...@jxu.me>.
> On Sept. 18, 2015, 10:22 p.m., Timothy Chen wrote:
> > src/slave/containerizer/provisioner/backends/copy.hpp, line 38
> > <https://reviews.apache.org/r/38511/diff/1/?file=1077069#file1077069line38>
> >
> > most of the comments makes sense.
> > however what do you mean by writing to root is not accounted for? what kind of accounting are you referring to?
The disk space it takes. Our current DiskIsolator doesn't count disk space outside the sandbox and it's not straightforward to just count the provisioned rootfs either because the user/task doesn't ask for it to be copied, the slave/operator decided it. Make sense?
I will update point 2) to make it more clear.
- Jiang Yan
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38511/#review99653
-----------------------------------------------------------
On Sept. 18, 2015, 3:13 p.m., Jiang Yan Xu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38511/
> -----------------------------------------------------------
>
> (Updated Sept. 18, 2015, 3:13 p.m.)
>
>
> Review request for mesos, Jie Yu, Jojy Varghese, and Timothy Chen.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> - We should investigate how to resolve these implications or disable/discourage the use of this backend in production after the overlay backend is committed.
>
>
> Diffs
> -----
>
> src/slave/containerizer/provisioner/backends/copy.hpp 10d9aee8c69e29e0cc9848fc5bde9919d0732b09
>
> Diff: https://reviews.apache.org/r/38511/diff/
>
>
> Testing
> -------
>
> N/A.
>
>
> Thanks,
>
> Jiang Yan Xu
>
>
Re: Review Request 38511: Added a warning comment to the copy
provisioner backend.
Posted by Timothy Chen <tn...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38511/#review99653
-----------------------------------------------------------
src/slave/containerizer/provisioner/backends/copy.hpp (line 38)
<https://reviews.apache.org/r/38511/#comment156614>
most of the comments makes sense.
however what do you mean by writing to root is not accounted for? what kind of accounting are you referring to?
- Timothy Chen
On Sept. 18, 2015, 10:13 p.m., Jiang Yan Xu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38511/
> -----------------------------------------------------------
>
> (Updated Sept. 18, 2015, 10:13 p.m.)
>
>
> Review request for mesos, Jie Yu, Jojy Varghese, and Timothy Chen.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> - We should investigate how to resolve these implications or disable/discourage the use of this backend in production after the overlay backend is committed.
>
>
> Diffs
> -----
>
> src/slave/containerizer/provisioner/backends/copy.hpp 10d9aee8c69e29e0cc9848fc5bde9919d0732b09
>
> Diff: https://reviews.apache.org/r/38511/diff/
>
>
> Testing
> -------
>
> N/A.
>
>
> Thanks,
>
> Jiang Yan Xu
>
>
Re: Review Request 38511: Added a warning comment to the copy
provisioner backend.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38511/#review99625
-----------------------------------------------------------
Ship it!
Ship It!
- Jie Yu
On Sept. 18, 2015, 10:13 p.m., Jiang Yan Xu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38511/
> -----------------------------------------------------------
>
> (Updated Sept. 18, 2015, 10:13 p.m.)
>
>
> Review request for mesos, Jie Yu, Jojy Varghese, and Timothy Chen.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> - We should investigate how to resolve these implications or disable/discourage the use of this backend in production after the overlay backend is committed.
>
>
> Diffs
> -----
>
> src/slave/containerizer/provisioner/backends/copy.hpp 10d9aee8c69e29e0cc9848fc5bde9919d0732b09
>
> Diff: https://reviews.apache.org/r/38511/diff/
>
>
> Testing
> -------
>
> N/A.
>
>
> Thanks,
>
> Jiang Yan Xu
>
>
Re: Review Request 38511: Added a warning comment to the copy
provisioner backend.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38511/#review99644
-----------------------------------------------------------
Patch looks great!
Reviews applied: [38511]
All tests passed.
- Mesos ReviewBot
On Sept. 18, 2015, 10:13 p.m., Jiang Yan Xu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38511/
> -----------------------------------------------------------
>
> (Updated Sept. 18, 2015, 10:13 p.m.)
>
>
> Review request for mesos, Jie Yu, Jojy Varghese, and Timothy Chen.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> - We should investigate how to resolve these implications or disable/discourage the use of this backend in production after the overlay backend is committed.
>
>
> Diffs
> -----
>
> src/slave/containerizer/provisioner/backends/copy.hpp 10d9aee8c69e29e0cc9848fc5bde9919d0732b09
>
> Diff: https://reviews.apache.org/r/38511/diff/
>
>
> Testing
> -------
>
> N/A.
>
>
> Thanks,
>
> Jiang Yan Xu
>
>