[GitHub] [activemq-artemis] clebertsuconic commented on a change in pull request #3841: ARTEMIS-3556 show message protocol on message view page

[GitBox <gi...@apache.org>]

clebertsuconic commented on a change in pull request #3841:
URL: https://github.com/apache/activemq-artemis/pull/3841#discussion_r745096534



##########
File path: artemis-core-client/src/main/java/org/apache/activemq/artemis/core/message/openmbean/MessageOpenTypeFactory.java
##########
@@ -123,6 +124,7 @@ protected void init() throws OpenDataException {
    public Map<String, Object> getFields(M m, int valueSizeLimit, int deliveryCount) throws OpenDataException {
       Map<String, Object> rc = new HashMap<>();
       rc.put(CompositeDataConstants.MESSAGE_ID, "" + m.getMessageID());
+      rc.put(CompositeDataConstants.PROTOCOL, m.getClass().getSimpleName());

Review comment:
       we could add a method on Message to return a more user friendly word? 
   
   on Message:
      public String getProtocol();
      
      
      then on core you return "CORE" and AMQP you return "AMQP"
      
      ?
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org