You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by GitBox <gi...@apache.org> on 2020/03/08 04:47:12 UTC
[GitHub] [incubator-pinot] quietgopher opened a new pull request #5128: Fix
a NullPointerException that can occur if an Exception is raised when
reading a JSON Record file.
quietgopher opened a new pull request #5128: Fix a NullPointerException that can occur if an Exception is raised when reading a JSON Record file.
URL: https://github.com/apache/incubator-pinot/pull/5128
_iterator will be null if an Exception is raised. _iterator.close() causes an NPE.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [incubator-pinot] codecov-io commented on issue #5128: Fix a
NullPointerException that can occur if an Exception is raised when reading
a JSON Record file.
Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #5128: Fix a NullPointerException that can occur if an Exception is raised when reading a JSON Record file.
URL: https://github.com/apache/incubator-pinot/pull/5128#issuecomment-596168460
# [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/5128?src=pr&el=h1) Report
> :exclamation: No coverage uploaded for pull request base (`master@a6c903d`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit).
> The diff coverage is `0%`.
[](https://codecov.io/gh/apache/incubator-pinot/pull/5128?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5128 +/- ##
=========================================
Coverage ? 57.56%
Complexity ? 12
=========================================
Files ? 1184
Lines ? 62420
Branches ? 9143
=========================================
Hits ? 35931
Misses ? 23847
Partials ? 2642
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-pinot/pull/5128?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...inot/plugin/inputformat/json/JSONRecordReader.java](https://codecov.io/gh/apache/incubator-pinot/pull/5128/diff?src=pr&el=tree#diff-cGlub3QtcGx1Z2lucy9waW5vdC1pbnB1dC1mb3JtYXQvcGlub3QtanNvbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvcGx1Z2luL2lucHV0Zm9ybWF0L2pzb24vSlNPTlJlY29yZFJlYWRlci5qYXZh) | `87.09% <0%> (ø)` | `12 <0> (?)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/5128?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/5128?src=pr&el=footer). Last update [a6c903d...63b939b](https://codecov.io/gh/apache/incubator-pinot/pull/5128?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [incubator-pinot] quietgopher commented on issue #5128: Fix a
NullPointerException that can occur if an Exception is raised when reading
a JSON Record file.
Posted by GitBox <gi...@apache.org>.
quietgopher commented on issue #5128: Fix a NullPointerException that can occur if an Exception is raised when reading a JSON Record file.
URL: https://github.com/apache/incubator-pinot/pull/5128#issuecomment-596166744
This diff fixes the following issue.
https://github.com/apache/incubator-pinot/issues/5129
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [incubator-pinot] fx19880617 merged pull request #5128: Fix a
NullPointerException that can occur if an Exception is raised when reading
a JSON Record file.
Posted by GitBox <gi...@apache.org>.
fx19880617 merged pull request #5128: Fix a NullPointerException that can occur if an Exception is raised when reading a JSON Record file.
URL: https://github.com/apache/incubator-pinot/pull/5128
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org