You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@tajo.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2015/06/04 18:18:37 UTC
[jira] [Commented] (TAJO-1636) query rest api uri should change from /databases/{database_name}/queies to /queries

    [ https://issues.apache.org/jira/browse/TAJO-1636?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14573073#comment-14573073 ] 

ASF GitHub Bot commented on TAJO-1636:
--------------------------------------

GitHub user charsyam opened a pull request:

    https://github.com/apache/tajo/pull/598

    TAJO-1636 query rest api uri should change from /databases/{database_name}/queies to /queries

    currently, "databases" Rest Api uri has too many meaning.
    1. for query
    2. to manage databases info
    and databases/
    {database_name}/queries is not proper for queries 
    
    so I suggest change from "/databases/{database_name}
    /queries" to
    "/queries/", it is more clear to understand.
    below apis will changed.
    POST /databases/{databaseName}/queries -> POST /queries
    GET /databases/{databaseName}/queries -> GET /queries
    GET /databases/{databaseName}/queries/{queryId} -> GET /queries/{queryId}
    GET /databases/{databaseName}/queries/{queryId}/result -> GET /queries/{queryId}/result
    GET /databases/{databaseName}/queries/{queryId}/result/{cacheId} -> GET /queries/{queryId}/result/{cacheId}

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/charsyam/tajo feature/change-query-api-address

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/tajo/pull/598.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #598
    
----
commit f068436b62ea934e26efa85b8b78a78ca64215b0
Author: clark.kang <cl...@kakao.com>
Date:   2015-06-04T15:39:47Z

    change-query-api-address

----


> query rest api uri should change from /databases/{database_name}/queies to /queries
> -----------------------------------------------------------------------------------
>
>                 Key: TAJO-1636
>                 URL: https://issues.apache.org/jira/browse/TAJO-1636
>             Project: Tajo
>          Issue Type: Improvement
>            Reporter: DaeMyung Kang
>            Assignee: DaeMyung Kang
>
> currently, "databases" Rest Api uri has too many meaning.
> 1. for query
> 2. to manage databases info
> and databases/
> {database_name}/queries is not proper for queries 
> so I suggest change from "/databases/{database_name}
> /queries" to
> "/queries/", it is more clear to understand.
> below apis will changed.
> POST /databases/{databaseName}/queries -> POST /queries
> GET /databases/{databaseName}/queries -> GET /queries
> GET /databases/{databaseName}/queries/{queryId} -> GET /queries/{queryId}
> GET /databases/{databaseName}/queries/{queryId}/result -> GET /queries/{queryId}/result
> GET /databases/{databaseName}/queries/{queryId}/result/{cacheId} -> GET /queries/{queryId}/result/{cacheId}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)