You are viewing a plain text version of this content. The canonical link for it is here.
Posted to scm-dev@maven.apache.org by "Dennis Lundberg (JIRA)" <ji...@codehaus.org> on 2006/01/17 22:37:40 UTC
[jira] Created: (SCM-134) Set CVSROOT consistently in all commands
in cvs-provider
Set CVSROOT consistently in all commands in cvs-provider
--------------------------------------------------------
Key: SCM-134
URL: http://jira.codehaus.org/browse/SCM-134
Project: Maven SCM
Type: Bug
Components: maven-scm-provider-cvs
Versions: 1.0-beta-3
Reporter: Dennis Lundberg
Attachments: SCM-134.patch
Most of the commands in the cvs provider use the command line argument "-d CVSROOT", but not all of them.
The attached patch adds "-d CVSROOT" to these commands:
* CvsDiffCommand
* CvsStatusCommand
* CvsUpdateCommand
This change also made it necessary to alter the CvsUpdateCommandTest so that it works on Windows.
That test now uses CvsScmTestUtils.getScmUrl() to get an scmUrl.
CvsScmTestUtils.getScmUrl() has been corrected to use the vertical bar "|" as the delimiter in all places of the scm url.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (SCM-134) Set CVSROOT consistently in all
commands in cvs-provider
Posted by "Trygve Laugstol (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/SCM-134?page=comments#action_56253 ]
Trygve Laugstol commented on SCM-134:
-------------------------------------
Is this really necessary? I would think that only the checkout and export commands (not sure if the latter exist) should set the CVSROOT as in all the other cases you already have an existing checkout and cvs should use the information stored there. I'm not sure what cvs will do if the given CVS root doesn't match what's in CVS/Root.
> Set CVSROOT consistently in all commands in cvs-provider
> --------------------------------------------------------
>
> Key: SCM-134
> URL: http://jira.codehaus.org/browse/SCM-134
> Project: Maven SCM
> Type: Bug
> Components: maven-scm-provider-cvs
> Versions: 1.0-beta-3
> Reporter: Dennis Lundberg
> Attachments: SCM-134.patch
>
>
> Most of the commands in the cvs provider use the command line argument "-d CVSROOT", but not all of them.
> The attached patch adds "-d CVSROOT" to these commands:
> * CvsDiffCommand
> * CvsStatusCommand
> * CvsUpdateCommand
> This change also made it necessary to alter the CvsUpdateCommandTest so that it works on Windows.
> That test now uses CvsScmTestUtils.getScmUrl() to get an scmUrl.
> CvsScmTestUtils.getScmUrl() has been corrected to use the vertical bar "|" as the delimiter in all places of the scm url.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (SCM-134) Set CVSROOT consistently in all
commands in cvs-provider
Posted by "Dennis Lundberg (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/SCM-134?page=comments#action_56508 ]
Dennis Lundberg commented on SCM-134:
-------------------------------------
I'm not sure if it necessary, but it should not hurt. The reason I found this is that I'm pursuing a bug in the maven-1 plugin. I thought that this inconsistency could have something to do with it, but it did not. Since I had already written the code I thought I might as well submit it.
You might want to consider the scm url related fixes.
> Set CVSROOT consistently in all commands in cvs-provider
> --------------------------------------------------------
>
> Key: SCM-134
> URL: http://jira.codehaus.org/browse/SCM-134
> Project: Maven SCM
> Type: Bug
> Components: maven-scm-provider-cvs
> Versions: 1.0-beta-3
> Reporter: Dennis Lundberg
> Attachments: SCM-134.patch
>
>
> Most of the commands in the cvs provider use the command line argument "-d CVSROOT", but not all of them.
> The attached patch adds "-d CVSROOT" to these commands:
> * CvsDiffCommand
> * CvsStatusCommand
> * CvsUpdateCommand
> This change also made it necessary to alter the CvsUpdateCommandTest so that it works on Windows.
> That test now uses CvsScmTestUtils.getScmUrl() to get an scmUrl.
> CvsScmTestUtils.getScmUrl() has been corrected to use the vertical bar "|" as the delimiter in all places of the scm url.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Closed: (SCM-134) Set CVSROOT consistently in all commands
in cvs-provider
Posted by "Emmanuel Venisse (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/SCM-134?page=all ]
Emmanuel Venisse closed SCM-134:
--------------------------------
Assign To: Emmanuel Venisse
Resolution: Fixed
Fix Version: 1.0-beta-3
Done by CvsCommandUtils class
> Set CVSROOT consistently in all commands in cvs-provider
> --------------------------------------------------------
>
> Key: SCM-134
> URL: http://jira.codehaus.org/browse/SCM-134
> Project: Maven SCM
> Type: Bug
> Components: maven-scm-provider-cvs
> Versions: 1.0-beta-3
> Reporter: Dennis Lundberg
> Assignee: Emmanuel Venisse
> Fix For: 1.0-beta-3
> Attachments: SCM-134.patch
>
>
> Most of the commands in the cvs provider use the command line argument "-d CVSROOT", but not all of them.
> The attached patch adds "-d CVSROOT" to these commands:
> * CvsDiffCommand
> * CvsStatusCommand
> * CvsUpdateCommand
> This change also made it necessary to alter the CvsUpdateCommandTest so that it works on Windows.
> That test now uses CvsScmTestUtils.getScmUrl() to get an scmUrl.
> CvsScmTestUtils.getScmUrl() has been corrected to use the vertical bar "|" as the delimiter in all places of the scm url.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira