You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by "nastra (via GitHub)" <gi...@apache.org> on 2024/04/03 07:46:56 UTC
[PR] Build: Ignore link-checking for Blogs / https://search.maven.org/ [iceberg]
nastra opened a new pull request, #10081:
URL: https://github.com/apache/iceberg/pull/10081
fixes https://github.com/apache/iceberg/issues/10060
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Build: Ignore link-checking for Blogs / https://search.maven.org/ [iceberg]
Posted by "nastra (via GitHub)" <gi...@apache.org>.
nastra commented on code in PR #10081:
URL: https://github.com/apache/iceberg/pull/10081#discussion_r1549253905
##########
site/docs/blogs.md:
##########
@@ -28,16 +28,19 @@ Here is a list of company blogs that talk about Iceberg. The blogs are ordered f
**Author**: [Alex Merced](https://www.linkedin.com/in/alexmerced/)
+<!-- markdown-link-check-disable-next-line -->
Review Comment:
good point, I should have done that but didn't realize such a setting is available
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Build: Ignore link-checking for Blogs / https://search.maven.org/ [iceberg]
Posted by "manuzhang (via GitHub)" <gi...@apache.org>.
manuzhang commented on code in PR #10081:
URL: https://github.com/apache/iceberg/pull/10081#discussion_r1549266453
##########
site/docs/blogs.md:
##########
@@ -28,16 +28,19 @@ Here is a list of company blogs that talk about Iceberg. The blogs are ordered f
**Author**: [Alex Merced](https://www.linkedin.com/in/alexmerced/)
+<!-- markdown-link-check-disable-next-line -->
Review Comment:
I was thinking about a workflow. When new blogs are added in a PR, they can be placed before `<!-- markdown-link-check-disable -->` to check link. When the link check passes, we place `<!-- markdown-link-check-disable -->` at the beginning again before merging the PR. That's a bit complex, though.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Build: Ignore link-checking for Blogs / https://search.maven.org/ [iceberg]
Posted by "manuzhang (via GitHub)" <gi...@apache.org>.
manuzhang commented on code in PR #10081:
URL: https://github.com/apache/iceberg/pull/10081#discussion_r1549266453
##########
site/docs/blogs.md:
##########
@@ -28,16 +28,19 @@ Here is a list of company blogs that talk about Iceberg. The blogs are ordered f
**Author**: [Alex Merced](https://www.linkedin.com/in/alexmerced/)
+<!-- markdown-link-check-disable-next-line -->
Review Comment:
I was thinking about a workflow. When new blogs are added in a PR, it can be placed before `<!-- markdown-link-check-disable -->`. When the link check passes, we place `<!-- markdown-link-check-disable -->` at the beginning again before merging the PR. That's a bit complex, though.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Build: Ignore link-checking for Blogs / https://search.maven.org/ [iceberg]
Posted by "manuzhang (via GitHub)" <gi...@apache.org>.
manuzhang commented on code in PR #10081:
URL: https://github.com/apache/iceberg/pull/10081#discussion_r1549244865
##########
site/docs/blogs.md:
##########
@@ -28,16 +28,19 @@ Here is a list of company blogs that talk about Iceberg. The blogs are ordered f
**Author**: [Alex Merced](https://www.linkedin.com/in/alexmerced/)
+<!-- markdown-link-check-disable-next-line -->
Review Comment:
Actually we only need to put `<!-- markdown-link-check-disable -->` and `<!-- markdown-link-check-enable-->` at the beginning and the end if we want to disable checking the whole doc.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Build: Ignore link-checking for Blogs / https://search.maven.org/ [iceberg]
Posted by "Fokko (via GitHub)" <gi...@apache.org>.
Fokko merged PR #10081:
URL: https://github.com/apache/iceberg/pull/10081
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org